From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5912C7EE23 for ; Sun, 4 Jun 2023 08:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To:Subject :MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sfXhf5HJgDnX1ZAfbfzJSTS4W+MU2gPcWf2z5/WiU2I=; b=P0skOVVYH7K0uo DMsTMiFyMxGGGQqEvtrtWBGP/G/uVq2UaMknIiIOFAfLBEoXdm8Sz+wQN++lv1ST54rhVh6mMwfE+ +ufPgKztonjDcbeIQMsz+lw037q4KQ1q2AdpI/YxmbSEFJKEbcXoDfWDfU3dTpxyrM5XAZ6h72RDE sGUwz83b8xDIn//MDNPV+p7UtEJ3Bf0UD3K1Yml6MutY474rM7mlP5vFjRRg9MybY0BV4GdyA7Vsm Smjq2wDazjmMOB+p6sGoqAIR07dFovzOuK/mtT7nghrkGgWFTpimhL0ViTpf/GesW663Z8cVM8lKz +ulgXn0XAbvdMwbJ4vLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q5iln-00BbBl-0b; Sun, 04 Jun 2023 08:07:23 +0000 Received: from sender4-op-o10.zoho.com ([136.143.188.10]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q5ilj-00BbAg-1R; Sun, 04 Jun 2023 08:07:20 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1685866005; cv=none; d=zohomail.com; s=zohoarc; b=PBkjITfkcgLIrj2ukmOM0fJ4ihuOMqEtafmR6mLgSGjFYsPWhsa/gIVDeFBxRvEV00S3RKY0KxRNzRIriDKzhx/meoRB2k62oCGQGX8q5t16jdELu89k2cjkr4V2zGtnBeYfbeEIgxXJvmI7RltKCCWhCdYiVL2BUjy8a0gFz1Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685866005; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=sfXhf5HJgDnX1ZAfbfzJSTS4W+MU2gPcWf2z5/WiU2I=; b=XO/GcWvk1dGtQphlY+JLIITYbd+c2jcZlNAdFTE3XvKRE6nbNvnwN8kVWpCw6DwvXHgPd0792ZuwZn8SE77mQS7qDuw7nqkV7NE6yE+kL31MKHULFA1KaQeYmNSVDk7nRF/7pOraSQKbIddZQV3Pm/40Zdg+RG5/qkZM7gJSHrE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1685866005; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=sfXhf5HJgDnX1ZAfbfzJSTS4W+MU2gPcWf2z5/WiU2I=; b=faOgHM7yJfCX/G92IExil29L7G5rtErAxx0mk8VSkP3ZmS8nxcLRVlhYuCYshZL+ KMeA9mHW0+XhK//TTuG01mIzt9Vyt8ct+X8qezLytZdYPzBK6+yhUwCP+fkdTcWEg+E ucMh091BVH2PsUjQ8b5C0OxIBiKTZjcVNWddMxVg= Received: from [192.168.66.198] (178-147-169-233.haap.dm.cosmote.net [178.147.169.233]) by mx.zohomail.com with SMTPS id 16858660033101021.621262772672; Sun, 4 Jun 2023 01:06:43 -0700 (PDT) Message-ID: Date: Sun, 4 Jun 2023 11:06:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH net-next 24/30] net: dsa: mt7530: rename MT7530_MFC to MT753X_MFC Content-Language: en-US To: "Russell King (Oracle)" , Vladimir Oltean References: <20230522121532.86610-1-arinc.unal@arinc9.com> <20230522121532.86610-25-arinc.unal@arinc9.com> <20230526154258.skbkk4p34ro5uivr@skbuf> From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230604_010719_539037_BC1B2D58 X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , linux-kernel@vger.kernel.org, Eric Dumazet , mithat.guner@xeront.com, Florian Fainelli , erkin.bozoglu@xeront.com, Richard van Schagen , Jakub Kicinski , Paolo Abeni , Landen Chao , Richard van Schagen , Sean Wang , DENG Qingfang , linux-mediatek@lists.infradead.org, Bartel Eerdekens , Matthias Brugger , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , netdev@vger.kernel.org, Daniel Golle , "David S. Miller" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 26.05.2023 18:50, Russell King (Oracle) wrote: > On Fri, May 26, 2023 at 06:42:58PM +0300, Vladimir Oltean wrote: >> On Mon, May 22, 2023 at 03:15:26PM +0300, arinc9.unal@gmail.com wrote: >>> /* Disable flooding on all ports */ >>> - mt7530_clear(priv, MT7530_MFC, BC_FFP_MASK | UNM_FFP_MASK | >>> - UNU_FFP_MASK); >>> + mt7530_clear(priv, MT753X_MFC, MT753X_BC_FFP_MASK | MT753X_UNM_FFP_MASK >>> + | MT753X_UNU_FFP_MASK); >> >> The preferred coding style is not to start new lines with operators. >> >>> +/* Register for CPU forward control */ >>> #define MT7531_CFC 0x4 >>> #define MT7531_MIRROR_EN BIT(19) >>> -#define MT7531_MIRROR_MASK (MIRROR_MASK << 16) >>> -#define MT7531_MIRROR_PORT_GET(x) (((x) >> 16) & MIRROR_MASK) >>> -#define MT7531_MIRROR_PORT_SET(x) (((x) & MIRROR_MASK) << 16) >>> +#define MT7531_MIRROR_MASK (0x7 << 16) >> >> minor nitpick: if you express this as GENMASK(18, 16), it will be a bit >> easier to cross-check with the datasheet, since both 18 and 16 are more >> representative than 0x7. >> >>> +#define MT7531_MIRROR_PORT_GET(x) (((x) >> 16) & 0x7) >> >> also here: (((x) & GENMASK(18, 16)) >> 16) > > Even better are: > #define MT7531_MIRROR_PORT_GET(x) FIELD_GET(MT7531_MIRROR_MASK, x) > >> >>> +#define MT7531_MIRROR_PORT_SET(x) (((x) & 0x7) << 16) >> >> and here: (((x) << 16) & GENMASK(18, 16)) > > #define MT7531_MIRROR_PORT_SET(x) FIELD_PREP(MT7531_MIRROR_MASK, x) > > No need to add parens around "x" in either of these uses as we're not > doing anything with x other than passing it into another macro. Thanks. I suppose the GENMASK, FIELD_PREP, and FIELD_GET macros can be widely used on mt7530.h? Like GENMASK(2, 0) on MT7530_MIRROR_MASK and FIELD_PREP(MT7530_MIRROR_MASK, x) on MT7530_MIRROR_PORT(x)? Arınç