From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Frank Wunderlich <frank-w@public-files.de>
Subject: Re: [PATCH v4] arm64: dts: mediatek: mt7986-bpi-r3: Change fan PWM value for mid speed
Date: Tue, 29 Jul 2025 12:13:58 +0200 [thread overview]
Message-ID: <e6246af6-eadf-4bee-9e1c-c17adb86b496@collabora.com> (raw)
In-Reply-To: <20250729075608.1651898-1-mikhail.kshevetskiy@iopsys.eu>
Il 29/07/25 09:56, Mikhail Kshevetskiy ha scritto:
> Popular cheap PWM fans for this machine, like the ones coming in
> heatsink+fan combos will not work properly at the currently defined
> medium speed. Trying different pwm setting using a command
>
> echo $value > /sys/devices/platform/pwm-fan/hwmon/hwmon1/pwm1
>
> I found:
>
> pwm1 value fan rotation speed cpu temperature notes
> -----------------------------------------------------------------
> 0 maximal 31.5 Celsius too noisy
> 40 optimal 35.2 Celsius no noise hearable
> 95 minimal
> above 95 does not rotate 55.5 Celsius
> -----------------------------------------------------------------
>
> Thus only cpu-active-high and cpu-active-low modes are usable.
> I think this is wrong.
>
> This patch fixes cpu-active-medium settings for bpi-r3 board.
>
> I know, the patch is not ideal as it can break pwm fan for some users.
> Likely this is the only official mt7986-bpi-r3 heatsink+fan solution
> available on the market.
>
> This patch may not be enough. Users may wants to tweak their thermal_zone0
> trip points, thus tuning fan rotation speed depending on cpu temperature.
> That can be done on the base of the following example:
>
> === example =========
> # cpu temperature below 25 Celsius degrees, no rotation
> echo 25000 > /sys/class/thermal/thermal_zone0/trip_point_4_temp
> # cpu temperature in [25..32] Celsius degrees, normal rotation speed
> echo 32000 > /sys/class/thermal/thermal_zone0/trip_point_3_temp
> # cpu temperature above 50 Celsius degrees, max rotation speed
> echo 50000 > /sys/class/thermal/thermal_zone0/trip_point_2_temp
> =====================
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
> Acked-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
prev parent reply other threads:[~2025-07-29 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 12:31 [PATCH v3] arm64: dts: mediatek: mt7986-bpi-r3: Change fan PWM value for mid speed Mikhail Kshevetskiy
2025-05-26 14:20 ` Frank Wunderlich
2025-07-29 7:56 ` [PATCH v4] " Mikhail Kshevetskiy
2025-07-29 10:13 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6246af6-eadf-4bee-9e1c-c17adb86b496@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox