Re: [PATCH v11 6/9] drm/mediatek: dpi: Support dynamic connector selection

["CK Hu (胡俊光)" <ck.hu@mediatek.com>]

Hi, Jason:

On Wed, 2023-10-04 at 10:40 +0800, Jason-JH.Lin wrote:
> Add implementation of mtk_dpi_encoder_index to mtk_ddp_comp_func
> to make mtk_dpi support dynamic connector selection.

Reviewed-by: CK Hu <ck.hu@mediatek.com>

> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_disp_drv.h     | 1 +
>  drivers/gpu/drm/mediatek/mtk_dpi.c          | 9 +++++++++
>  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 +
>  3 files changed, 11 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_drv.h
> b/drivers/gpu/drm/mediatek/mtk_disp_drv.h
> index 2254038519e1..5f07037670e9 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_drv.h
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_drv.h
> @@ -44,6 +44,7 @@ void mtk_dither_set_common(void __iomem *regs,
> struct cmdq_client_reg *cmdq_reg,
>  
>  void mtk_dpi_start(struct device *dev);
>  void mtk_dpi_stop(struct device *dev);
> +unsigned int mtk_dpi_encoder_index(struct device *dev);
>  
>  void mtk_dsi_ddp_start(struct device *dev);
>  void mtk_dsi_ddp_stop(struct device *dev);
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 2f931e4e2b60..4e3d9f7b4d8c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -781,6 +781,15 @@ void mtk_dpi_stop(struct device *dev)
>  	mtk_dpi_power_off(dpi);
>  }
>  
> +unsigned int mtk_dpi_encoder_index(struct device *dev)
> +{
> +	struct mtk_dpi *dpi = dev_get_drvdata(dev);
> +	unsigned int encoder_index = drm_encoder_index(&dpi->encoder);
> +
> +	dev_dbg(dev, "encoder index:%d\n", encoder_index);
> +	return encoder_index;
> +}
> +
>  static int mtk_dpi_bind(struct device *dev, struct device *master,
> void *data)
>  {
>  	struct mtk_dpi *dpi = dev_get_drvdata(dev);
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> index 02f0ada3754b..601755925520 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> @@ -304,6 +304,7 @@ static const struct mtk_ddp_comp_funcs ddp_dither
> = {
>  static const struct mtk_ddp_comp_funcs ddp_dpi = {
>  	.start = mtk_dpi_start,
>  	.stop = mtk_dpi_stop,
> +	.encoder_index = mtk_dpi_encoder_index,
>  };
>  
>  static const struct mtk_ddp_comp_funcs ddp_dsc = {