Re: [PATCH v2 4/9] soc: mailbox: Add cmdq_pkt_write_s_reg_value to support write value to reg

Jason-JH Lin (林睿祥)
2023-10-25T00:45:33Z

Hi Angelo,

Thanks for the reviews.

On Mon, 2023-10-23 at 11:50 +0200, AngeloGioacchino Del Regno wrote:
> Il 23/10/23 06:37, Jason-JH.Lin ha scritto:
> > Add cmdq_pkt_write_s_reg_value to support write a value to a
> > register.
> >
> > It appends write_s command to the command buffer in a CMDQ packet,
> > ask GCE to excute a write instruction to write a value to a
> > register
> > with low 16 bits physical address offset.
> >
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
>
> Please fix the commit title:
>
> soc: mediatek: cmdq: xxxx
>
OK, I'll fix that. Thanks!

Regards,
Jason-JH.Lin

> Regards,
> Angelo
>