[PATCH] clk: mediatek: Use devm_alloc for clk_data allocation to fix memory leak on probe error

Haotian Zhang
2025-09-29T02:36:43Z

The probe functions for the mt6765 apmixed, top, and infrasys clocks
use mtk_alloc_clk_data() to allocate memory. This requires manual
freeing of the memory in all error handling paths and in the driver's
remove function.

Switch to mtk_devm_alloc_clk_data() in order to fix the memory leak in the
probe function.

Fixes: 1aca9939bf72 ("clk: mediatek: Add MT6765 clock support")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
drivers/clk/mediatek/clk-mt6765.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/mediatek/clk-mt6765.c b/drivers/clk/mediatek/clk-mt6765.c
index d53731e7933f..5cfb9a3a5ee3 100644
--- a/drivers/clk/mediatek/clk-mt6765.c
+++ b/drivers/clk/mediatek/clk-mt6765.c
@@ -736,7 +736,7 @@ static int clk_mt6765_apmixed_probe(struct platform_device *pdev)
if (IS_ERR(base))
return PTR_ERR(base);

- clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
+ clk_data = mtk_devm_alloc_clk_data(CLK_APMIXED_NR_CLK);
if (!clk_data)
return -ENOMEM;

@@ -770,7 +770,7 @@ static int clk_mt6765_top_probe(struct platform_device *pdev)
if (IS_ERR(base))
return PTR_ERR(base);

- clk_data = mtk_alloc_clk_data(CLK_TOP_NR_CLK);
+ clk_data = mtk_devm_alloc_clk_data(CLK_TOP_NR_CLK);
if (!clk_data)
return -ENOMEM;

@@ -810,7 +810,7 @@ static int clk_mt6765_ifr_probe(struct platform_device *pdev)
if (IS_ERR(base))
return PTR_ERR(base);

- clk_data = mtk_alloc_clk_data(CLK_IFR_NR_CLK);
+ clk_data = mtk_devm_alloc_clk_data(CLK_IFR_NR_CLK);
if (!clk_data)
return -ENOMEM;

--
2.50.1.windows.1