From: Matthias Brugger <matthias.bgg@gmail.com>
To: Dawei Chien <dawei.chien@mediatek.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@armlinux.org.uk>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
Sascha Hauer <kernel@pengutronix.de>,
Fan Chen <fan.chen@mediatek.com>,
Eddie Huang <eddie.huang@mediatek.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
Erin Lo <erin.lo@mediatek.com>
Subject: Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups
Date: Thu, 9 Feb 2017 22:25:36 +0100 [thread overview]
Message-ID: <ebdf54af-6290-9654-c475-53dd580582a0@gmail.com> (raw)
In-Reply-To: <1486531862-31945-1-git-send-email-dawei.chien@mediatek.com>
On 02/08/2017 06:31 AM, Dawei Chien wrote:
> Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors.
> However, Currently thermal driver don't need read TEMP_MSR3 since
> thermal controller only use 3 sensors for each thermal bank.
>
> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com>
> ---
Actually the commit message should state:
Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.")
...and get backported to v4.9 and v4.10.
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Regards,
Matthias
> drivers/thermal/mtk_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 34169c3..c124151 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -191,7 +191,7 @@ struct mtk_thermal {
> };
>
> const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = {
> - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2
> + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3
> };
>
> const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = {
>
next prev parent reply other threads:[~2017-02-09 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 5:31 [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Dawei Chien
2017-02-09 21:25 ` Matthias Brugger [this message]
[not found] ` <ebdf54af-6290-9654-c475-53dd580582a0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-13 9:01 ` Dawei Chien
2017-02-19 1:23 ` Eduardo Valentin
[not found] ` <20170219012306.GA28525-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-02-20 11:30 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebdf54af-6290-9654-c475-53dd580582a0@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=dawei.chien@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=edubezval@gmail.com \
--cc=erin.lo@mediatek.com \
--cc=fan.chen@mediatek.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox