From: Johannes Berg <johannes@sipsolutions.net>
To: Lorenzo Bianconi <lorenzo@kernel.org>, nbd@nbd.name
Cc: linux-mediatek@lists.infradead.org, lorenzo.bianconi@redhat.com,
ryder.lee@mediatek.com, linux-wireless@vger.kernel.org,
sean.wang@mediatek.com
Subject: Re: [PATCH] mt76: mt7663: introduce ARP filter offload
Date: Fri, 05 Jun 2020 09:21:09 +0200 [thread overview]
Message-ID: <ec6ea6eea17d7e8a6abaf35e78ffac7568e54831.camel@sipsolutions.net> (raw)
In-Reply-To: <e91990d20a1a5f8d134fc9d9df152d9356fd15f9.1591340650.git.lorenzo@kernel.org> (sfid-20200605_090717_383122_E28D553B)
On Fri, 2020-06-05 at 09:07 +0200, Lorenzo Bianconi wrote:
>
> + .arp = {
> + .tag = cpu_to_le16(UNI_OFFLOAD_OFFLOAD_ARP),
> + .len = cpu_to_le16(sizeof(struct mt7615_arpns_tlv)),
> + .ips_num = info->arp_addr_cnt,
Surely there's *some* hardware limit, after which you need to disable
the filter? Or does the firmware take the data and discard it, it it's
got too many IPs?
At the very least, only 255 fit in there, and at least theoretically you
can assign more to the netdev :)
johannes
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2020-06-05 7:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 7:07 [PATCH] mt76: mt7663: introduce ARP filter offload Lorenzo Bianconi
2020-06-05 7:21 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec6ea6eea17d7e8a6abaf35e78ffac7568e54831.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox