Re: [PATCH] wifi: mt76: mt7915: enable BSS_CHANGED_MU_GROUPS support

[Ryder Lee <Ryder.Lee@mediatek.com>]

On Thu, 2023-08-03 at 07:58 +0300, Kalle Valo wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  Ryder Lee <ryder.lee@mediatek.com> writes:
> 
> > The Group ID Management frame is an Action frame of category VHT.
> > It is transmitted by the AP to assign or change the user position
> > of a STA for one or more group IDs.
> >
> > Also, sniffer can use a given group id to monitor STA that belongs
> > to that group.
> >
> > Notify underlying driver of changes via BSS_CHANGED_MU_GROUPS.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > Change-Id: I3d2f5508a2b6eb7c929c3997c31a9285713c8bea
> 
> No Change-Id, please.
> 
ok.

> > --- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> > @@ -593,6 +593,34 @@ mt7915_update_bss_color(struct ieee80211_hw
> *hw,
> >  	}
> >  }
> >  
> > +static void
> > +mt7915_update_mu_group(struct ieee80211_hw *hw, struct
> ieee80211_vif *vif,
> > +		       struct ieee80211_bss_conf *info)
> > +{
> > +	struct mt7915_phy *phy = mt7915_hw_phy(hw);
> > +	struct mt7915_dev *dev = mt7915_hw_dev(hw);
> > +	u8 i, band = phy->mt76->band_idx;
> > +	u32 *mu;
> > +
> > +	mu = (u32 *)info->mu_group.membership;
> 
> Is this safe on big endian?
> 

hmmm, I'm thinking about this. Doesn't this byte array covert (and
then write) to the same cpu endianess?

__le32 mu = (__le32 *)info->mu_group.membership
write(..., le32_to_cpu(mu));
I know something like above change is safe, but just checking...

RYder