From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [v2 PATCH 4/4] phy: phy-meson-gxl-usb2: get optional clock by devm_clk_get_optional() Date: Wed, 10 Apr 2019 10:18:47 +0200 Message-ID: References: <9f04a619e8a2cc44f5b1fe299a08f237f069d56d.1554874961.git.chunfeng.yun@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9f04a619e8a2cc44f5b1fe299a08f237f069d56d.1554874961.git.chunfeng.yun@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Chunfeng Yun , Kishon Vijay Abraham I Cc: Kevin Hilman , Matthias Brugger , Andy Gross , David Brown , Masahiro Yamada , Martin Blumenstingl , Grygorii Strashko , Kunihiko Hayashi , Masami Hiramatsu , Motoya Tanigawa , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org On Wed, 2019-04-10 at 14:13 +0800, Chunfeng Yun wrote: > Use devm_clk_get_optional() to get optional clock > > Cc: Martin Blumenstingl > Signed-off-by: Chunfeng Yun > Acked-by: Martin Blumenstingl Reviewed-by: Jerome Brunet > --- > v2: add Acked-by Martin Blumenstingl > --- > drivers/phy/amlogic/phy-meson-gxl-usb2.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/phy/amlogic/phy-meson-gxl-usb2.c b/drivers/phy/amlogic/phy-meson-gxl-usb2.c > index 148ef0bdb9c1..4cbee412f2b0 100644 > --- a/drivers/phy/amlogic/phy-meson-gxl-usb2.c > +++ b/drivers/phy/amlogic/phy-meson-gxl-usb2.c > @@ -261,14 +261,9 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev) > if (IS_ERR(priv->regmap)) > return PTR_ERR(priv->regmap); > > - priv->clk = devm_clk_get(dev, "phy"); > - if (IS_ERR(priv->clk)) { > - ret = PTR_ERR(priv->clk); > - if (ret == -ENOENT) > - priv->clk = NULL; > - else > - return ret; > - } > + priv->clk = devm_clk_get_optional(dev, "phy"); > + if (IS_ERR(priv->clk)) > + return PTR_ERR(priv->clk); > > priv->reset = devm_reset_control_get_optional_shared(dev, "phy"); > if (IS_ERR(priv->reset))