From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E7FC433E7 for ; Wed, 14 Oct 2020 10:23:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1861A20723 for ; Wed, 14 Oct 2020 10:23:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jbA7ykVV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b="dOhmbIhM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1861A20723 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nbd.name Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cz6s5t1ItfZTsmzC3Jn3dSQTAQQW88/oInD4sJEP4Uo=; b=jbA7ykVVJCwxbJPLLt6JNYor+ 6nD3//nNOiQI3krjKrvA0LfVuhJ7+M6Cy3nxDrqt0GPVcXZr6Uuk3vXgZjdrg6P1R3qjXssDh9WgI XO58/yGfRdZTXQVXB7+BYgJKTczKfC75yRKWLTgy9R/fiomhDeHGXtLcYa764ye5fHZwTsYHqvrgg bS3t9doYoes04b6A9ckXkqCT/bruHS63ECWLE7yPhUeMFY/jgC77sGLQ+HwNb0kuJtzypjk9599nE mmq24unnjsDJf7aGNesZX869+3k/mX2C/xEzQNvNeysWzcn63m9qJtD/L/J2ejXkVWj2x4F6wi7yh v27vczV3g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSdwM-0008LQ-Cr; Wed, 14 Oct 2020 10:23:26 +0000 Received: from nbd.name ([2a01:4f8:221:3d45::2]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSdw2-0008Ag-4Y for linux-mediatek@lists.infradead.org; Wed, 14 Oct 2020 10:23:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:Subject:From:References:Cc:To:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=opmjH3ZyRO0Bff677ZBbUzYgvMkp277MTfGEMgeatCU=; b=dOhmbIhMtzC/KSlYzY59O9AsWA ligtv8fOtHVF8xYckjShbCe4xOMbHtDT7PJ3PX89GRAFa7kfLY2Ntuz0tty/hwvhx4FAg2eaHasi1 lAxLgFOwVbkRSqsEHQqV/hXD8eAymrw1gwW4q3/KCAFKNzzqDNh91AezOfd8M0/+glmI=; Received: from p54ae9462.dip0.t-ipconnect.de ([84.174.148.98] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1kSdvx-0003kZ-J4; Wed, 14 Oct 2020 12:23:01 +0200 To: Shayne Chen References: <20201012125403.8608-1-shayne.chen@mediatek.com> <20201012125403.8608-8-shayne.chen@mediatek.com> From: Felix Fietkau Subject: Re: [PATCH v3 08/10] mt76: mt7915: implement testmode rx support Message-ID: Date: Wed, 14 Oct 2020 12:23:00 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201012125403.8608-8-shayne.chen@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_062306_456545_004F04BD X-CRM114-Status: GOOD ( 18.27 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mediatek , Lorenzo Bianconi , Ryder Lee , linux-wireless , Evelyn Tsai Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 2020-10-12 14:54, Shayne Chen wrote: > Support testmode rx and display rx statistic by parsing RXV packet > type, which is currently only enabled in testmode. > > Reviewed-by: Ryder Lee > Signed-off-by: Shayne Chen > --- > v2: change last_snr to u8 > v3: use nla_put_u8 for MT76_TM_RX_ATTR_SNR > change snr variable type to u8 in mt7915_mac_fill_rx_vector > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c > index 5d95766..acab268 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c > @@ -113,6 +113,31 @@ mt7915_tm_reg_backup_restore(struct mt7915_dev *dev, struct mt7915_phy *phy) > mt76_clear(dev, MT_TMAC_TCR0(0), MT_TMAC_TCR0_TBTT_STOP_CTRL); > } > > +static int > +mt7915_tm_config_rx_filter(struct mt7915_dev *dev, bool en) > +{ > + struct mt7915_tm_cmd req = { > + .testmode_en = 1, > + .param_idx = MCU_ATE_SET_RX_FILTER, > + .param.filter.report_en = en, > + .param.filter.band = 0, /* TODO: support dbdc */ > + }; > + __le32 mask = RX_FILTER_NOT_OWN_BTIM | > + RX_FILTER_NOT_OWN_UCAST | > + RX_FILTER_RTS | RX_FILTER_CTS | > + RX_FILTER_CTRL_RSV | > + RX_FILTER_BC_MC_BSSID_A2 | > + RX_FILTER_BC_MC_BSSID_A3 | > + RX_FILTER_BC_MC_OMAC_A3 | > + RX_FILTER_PROTOCOL_VERSION | > + RX_FILTER_FCS_ERR; > + > + req.param.filter.mask = cpu_to_le32(mask); > + > + return mt76_mcu_send_msg(&dev->mt76, MCU_EXT_CMD_ATE_CTRL, &req, > + sizeof(req), false); Why do we need this? In order to use testmode you have to set up a monitor mode interface, which should configure the rx filter settings properly already. - Felix _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek