From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Fei Shao <fshao@chromium.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Jieyy Yang <jieyy.yang@mediatek.com>,
Jian Yang <jian.yang@mediatek.com>,
Jianguo Zhang <jianguo.zhang@mediatek.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Seiya Wang <seiya.wang@mediatek.com>,
Tinghan Shen <tinghan.shen@mediatek.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Alexandre Mergnat <amergnat@baylibre.com>,
"Bear Wang" <bear.wang@mediatek.com>,
Pablo Sun <pablo.sun@mediatek.com>,
"Macpaul Lin" <macpaul@gmail.com>, Sen Chu <sen.chu@mediatek.com>,
Chris-qj chen <chris-qj.chen@mediatek.com>,
MediaTek Chromebook Upstream
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
Chen-Yu Tsai <wenst@chromium.org>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
Date: Wed, 9 Oct 2024 16:49:56 +0800 [thread overview]
Message-ID: <f1bb941b-cb6d-32c4-2cf9-268fc3f43bf9@mediatek.com> (raw)
In-Reply-To: <CAC=S1ngrsDxQ1Fe9xB_EevGbGB5nDoCB_n2oGb2VTLiv1vSsGA@mail.gmail.com>
On 10/8/24 15:10, Fei Shao wrote:
>
>
> External email : Please do not click links or open attachments until you
> have verified the sender or the content.
>
> On Tue, Oct 8, 2024 at 1:36 PM Macpaul Lin <macpaul.lin@mediatek.com> wrote:
>>
>> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
>> The error message was:
>> t-phy@11e30000: 'power-domains' does not match any of the regexes:
>> '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>> Fix this issue by dropping 'power-domains' of u3phy1 node.
>>
>> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>
> Apart from this, can you or Chunfeng confirm if we should make a
> similar change for MT8188[1]?
>
> [1]: https://lore.kernel.org/all/20241004081218.55962-3-fshao@chromium.org/
>
> Regards,
> Fei
>
According to the suggestion and discussion in
[1]:
https://lore.kernel.org/lkml/20241008-disorder-slacking-d8196ceb68f7@spud/T/#mccf978d76f52cc26970f3f3be6120055e4698fe6
I think adding 'power-domains' to PCIE node of MT8188 is okay.
Thanks
Macpaul Lin
next prev parent reply other threads:[~2024-10-09 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 5:35 [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy Macpaul Lin
2024-10-08 6:45 ` Chen-Yu Tsai
2024-10-08 7:10 ` Fei Shao
2024-10-09 8:49 ` Macpaul Lin [this message]
2024-10-09 10:55 ` Fei Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1bb941b-cb6d-32c4-2cf9-268fc3f43bf9@mediatek.com \
--to=macpaul.lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bear.wang@mediatek.com \
--cc=chris-qj.chen@mediatek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fshao@chromium.org \
--cc=jian.yang@mediatek.com \
--cc=jianguo.zhang@mediatek.com \
--cc=jieyy.yang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=pablo.sun@mediatek.com \
--cc=robh@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=sen.chu@mediatek.com \
--cc=tinghan.shen@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox