Re: [PATCH] clk: mediatek: add mt7981 clock support

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 15/11/22 03:10, Jianhui Zhao ha scritto:
> Signed-off-by: Jianhui Zhao <zhaojh329@gmail.com>


There's no commit description, and you definitely need one.

> ---
>   .../bindings/clock/mediatek,apmixedsys.yaml   |   1 +
>   .../bindings/clock/mediatek,topckgen.yaml     |   1 +

Documentation/bindings patches shall be split from this one and if you
ever ran checkpatch.pl you would know...

>   drivers/clk/mediatek/Kconfig                  |  17 +
>   drivers/clk/mediatek/Makefile                 |   4 +
>   drivers/clk/mediatek/clk-mt7981-apmixed.c     | 103 +++++
>   drivers/clk/mediatek/clk-mt7981-eth.c         | 138 ++++++
>   drivers/clk/mediatek/clk-mt7981-infracfg.c    | 323 +++++++++++++
>   drivers/clk/mediatek/clk-mt7981-topckgen.c    | 431 ++++++++++++++++++
>   include/dt-bindings/clock/mt7981-clk.h        | 253 ++++++++++
>   9 files changed, 1271 insertions(+)
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-apmixed.c
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-eth.c
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-infracfg.c
>   create mode 100644 drivers/clk/mediatek/clk-mt7981-topckgen.c
>   create mode 100644 include/dt-bindings/clock/mt7981-clk.h

...and your Cc list is not as it should be.

So, I won't review this patch as there's too many wrongs... but if you really
want to contribute (please, do!!!), you should start by taking a look at:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Best regards,
Angelo