From: Florian Fainelli <f.fainelli@gmail.com>
To: Sean Wang <sean.wang@mediatek.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
open list <linux-kernel@vger.kernel.org>,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net] net: dsa: mt7530: Use NULL instead of plain integer
Date: Tue, 3 Apr 2018 10:02:40 -0700 [thread overview]
Message-ID: <f5aa0467-8124-b097-2b89-dcf1698a5ba5@gmail.com> (raw)
In-Reply-To: <1522721904.18424.51.camel@mtkswgap22>
On 04/02/2018 07:18 PM, Sean Wang wrote:
> On Mon, 2018-04-02 at 16:24 -0700, Florian Fainelli wrote:
>> We would be passing 0 instead of NULL as the rsp argument to
>> mt7530_fdb_cmd(), fix that.
>>
>
> Acked-by: Sean Wang <sean.wang@mediatek.com>
>
> BTW, does the part of the commit message should be updated with "passing
> NULL instead of 0"?
I don't follow you, the commit message indicates what we were doing
which implies it was wrong and fixes it. Would you want me to reword
that part?
--
Florian
next prev parent reply other threads:[~2018-04-03 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180402232414.19671-1-f.fainelli@gmail.com>
[not found] ` <20180402232414.19671-1-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-04-03 2:18 ` [PATCH net] net: dsa: mt7530: Use NULL instead of plain integer Sean Wang
2018-04-03 17:02 ` Florian Fainelli [this message]
[not found] ` <f5aa0467-8124-b097-2b89-dcf1698a5ba5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-04-03 17:31 ` Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5aa0467-8124-b097-2b89-dcf1698a5ba5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox