From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63712C77B7F for ; Mon, 8 May 2023 08:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m5LglcJTmAOL674iFSW91v8iQ+c+VWN66eezYdcY/eo=; b=t9rORNKT17WsehGY4O8Q9F52E7 q6Og9bDg0fJS7GWu9PgwDxvHk0utp3LoZMe/o0GIzKna43B7svQafXI+JNqUULwbMs9Sxl/41ZbUS fbkOYplvq6pZeLnTOrWB9B3MqMYScWaQ5PH3Qodkrc1vSj+aaSK956gGZTvqnYh+uCtTkHGW5hUYC dJ6j5PBw5e/t3xflF8iZrgvv8rZ+GUFWXj57TNuF4d9/BPBvn6C2T+hhNNbphK9QIQC/dYSg1F1ES JyoQlB2ZeGXk+uh03WFNdYerW6o3xrIRki8OX7QrIrkPRA/jh2kyyX1+w4Q9w94wKyFlZVpCM/cLV HfdSQ0Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pvwAV-00HZaU-17; Mon, 08 May 2023 08:24:27 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pvwAT-00HZZK-08; Mon, 08 May 2023 08:24:26 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f415a9015bso22278295e9.2; Mon, 08 May 2023 01:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683534263; x=1686126263; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m5LglcJTmAOL674iFSW91v8iQ+c+VWN66eezYdcY/eo=; b=FkoBtct+K+FHjRPlHL9ykOQXt4jjYt99V2O+8Vje8XlvSQzc6v+6j4rXJJruHwHd5I wj2Hp+C2JBQLstF/iJcFcUWQRCc1HgKdzlVL4cXoWSeXlt0Z5chr0kXEnr/CttPDrlbY x2QIlOimiAyMBchumS0veYf//2RtScWx9T2KoBIqrvzBuKroy1jh6B5sGhEZg3rpDDwW 4JtorSK0X+Dzb8JNk9ZJ4KEx3ovHxrpZF3/S01fHY/WUoBD8Iy3Xff68c6hi21Ii+H/1 51Bt4xy/tufm5jMIKbRql0n/WodjbVuz0M9OOYXrUP1Y5dTSFRLbwg5KNCSV0fIg2hbg ERbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683534263; x=1686126263; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m5LglcJTmAOL674iFSW91v8iQ+c+VWN66eezYdcY/eo=; b=CK5O8w9/BkFaBCLLgPPSoN5ZRfWm91bzKnHkOUogHrn1BFZY67U8U++RyON3Fgt1tO eCLo+SiBMlpdujSbmTJJ6U3G5Cy4UwAEvZm8u8gHaEVnSiwistkxHrB/OCYN4r9sAO2A OJlWv+avG8hO1Oksi+RnSj2RD39nBJBCvdrvfqubTwX6DlA3lQO4oXdYIENhW9WBMOLA ieENOPgd/xgsNhOpSTwh/rwBHBEA7BRm/nShzamjI62HjoPE8pqDoUR0EfCIdirOqA6N Qddjbvf1rOXMf0qma9SyTQ0B0PDApb+7qihBvrb7FGCzK4q1S+NSdw1aEwICTAcI8hRv 6yGw== X-Gm-Message-State: AC+VfDz8/ILxF/5ZOVH0pAwy0gYTBlAqnZBYMRD/Hw+dvQv/8uDdCqHi AzNN5guxeXDWEDps3HGAFpc= X-Google-Smtp-Source: ACHHUZ7qgZXuInT52CBe2fdIODHvN3TsFZFGNC53yWfuzxRIbJsq0WD/6yJNKLgPzMeJ/5eb9LSI8A== X-Received: by 2002:a05:600c:2191:b0:3f4:1a97:ab1d with SMTP id e17-20020a05600c219100b003f41a97ab1dmr4138816wme.1.1683534262558; Mon, 08 May 2023 01:24:22 -0700 (PDT) Received: from [192.168.2.177] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id s13-20020a05600c45cd00b003f1738d0d13sm19383989wmo.1.2023.05.08.01.24.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 01:24:21 -0700 (PDT) Message-ID: Date: Mon, 8 May 2023 10:24:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] phy: mediatek: fix returning garbage Content-Language: en-US, ca-ES, es-ES To: Vinod Koul Cc: Tom Rix , chunkuang.hu@kernel.org, p.zabel@pengutronix.de, chunfeng.yun@mediatek.com, kishon@kernel.org, angelogioacchino.delregno@collabora.com, nathan@kernel.org, ndesaulniers@google.com, granquet@baylibre.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20230414122253.3171524-1-trix@redhat.com> From: Matthias Brugger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230508_012425_076563_240449D1 X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 08/05/2023 09:48, Vinod Koul wrote: > On 05-05-23, 17:37, Matthias Brugger wrote: >> >> >> On 05/05/2023 11:28, Vinod Koul wrote: >>> On 14-04-23, 08:22, Tom Rix wrote: >>>> clang reports >>>> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable >>>> 'ret' is uninitialized when used here [-Werror,-Wuninitialized] >>>> if (ret) >>>> ^~~ >>>> ret should have been set by the preceding call to mtk_hdmi_pll_set_hw. >>> >>> I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable >>> usage in pll_calc" >> >> Thanks Vinod, that was on my list for today as well. I was a bit puzzled >> because you took the patch that added it, but I wasn't sure if you would >> take the fix. How do you want to handle things like this in the future? > > Fixes should be sent as Fixes patch > I'm not sure what do you mean. Patch subject includes the word fix and the patch has a fixes tag. What was missing here? Does this mean you will take fixes for this driver in the future or do you want me to take care of them? Regards, Matthias