From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C51B4C83F09 for ; Wed, 9 Jul 2025 07:53:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K3AjXyLDTKwSi4JFt5qXXHU8GLdo56uvhZ7Y+buDpoM=; b=NWA+3924TtagAHsVwsH/HWCWSs Enrhr4G9QmdwsFElLVOp7alGPIYWlfKRCnIz9hTGZFvwOle2clcR7k2S+0QKy6a0YqazlHlFpiAV5 ptmQ8TDYdZjRPxITf8nm90baMoPl89N3a/KkQwqLf/HHKhr99xJP9gxd/eJqjfmLpepf6GuFG9l/L BUoIJVnAjeTuhkWRKi4YmHxzz61b+/Dt4nErbB9ywIA/8Daj/KLgJGzKum+MeAqc5GHTRxYQu/Q9k +/0akPCqSFSh2ggbcOgk1GdcAF5zN2j0N6+V74VeEnx9HB3R5BJUGrbcXEJ4kc2R2n4sNT8EOxD/i vaam3Ktg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZPcq-00000007rX0-23kI; Wed, 09 Jul 2025 07:53:56 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZOmK-00000007kBG-126n; Wed, 09 Jul 2025 06:59:41 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 87AF55C6618; Wed, 9 Jul 2025 06:59:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BB3EC4CEF0; Wed, 9 Jul 2025 06:59:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752044379; bh=YlqJmXdkohNFHXYMBpBaX+PVFLgGz8jmw+qFDTmc/nM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bpIWlexsjygi5fpwUefLkBJCyw8+pGqTQavsSu3PUnNkQ7DAAkww/DXagNBPRSvCX EmSylVEJpycqIGB34dJJGmpoU2deRhRAC/PmTVSgAt14BiZ0K88IfviaX0U0vOaEb3 4hD9Fsuk7lTnZCjOgsmf4UgcZRRkZoDW5l7kO2Qyir1Afxjvp2Lb1D68hotDPW9181 uFxlULKicrO+nlngPaQL1A8h0upF9Ndzwzbglv2zUzInxDfEOdX6Hrk/X6ZLieMrbl hPeSlF2Y0gU6l6jWySsmKr9Wq2/Dxh+8KpxwgZUhuX5HIb46bkdo0jJn4+W4IIT4P9 SNQvHFzTB8Vjg== Message-ID: Date: Wed, 9 Jul 2025 08:59:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: dsp: mediatek: add mt8196 dsp document To: =?UTF-8?B?SGFpbG9uZyBGYW4gKOiMg+a1t+m+mSk=?= , "perex@perex.cz" , "pierre-louis.bossart@linux.dev" , "kai.vehmanen@linux.intel.com" , "broonie@kernel.org" , "conor+dt@kernel.org" , "tiwai@suse.com" , "robh@kernel.org" , "lgirdwood@gmail.com" , "yung-chuan.liao@linux.intel.com" , "matthias.bgg@gmail.com" , "peter.ujfalusi@linux.intel.com" , "krzk+dt@kernel.org" , "daniel.baluta@nxp.com" , AngeloGioacchino Del Regno , "ranjani.sridharan@linux.intel.com" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-sound@vger.kernel.org" , "sound-open-firmware@alsa-project.org" , "devicetree@vger.kernel.org" , Project_Global_Chrome_Upstream_Group References: <20250703075632.20758-1-hailong.fan@mediatek.com> <20250703075632.20758-2-hailong.fan@mediatek.com> <61784658-c71d-458b-8934-5f5db2330bc0@collabora.com> <85ca4ceb29caec9acbe77a3d67e3bc57b0b0aeb5.camel@mediatek.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <85ca4ceb29caec9acbe77a3d67e3bc57b0b0aeb5.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250708_235940_374603_D81A8554 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 09/07/2025 08:34, Hailong Fan (范海龙) wrote: > On Thu, 2025-07-03 at 11:05 +0200, AngeloGioacchino Del Regno wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> Il 03/07/25 10:08, Krzysztof Kozlowski ha scritto: >>> On 03/07/2025 09:56, hailong.fan wrote: >>>> From: Hailong Fan >>>> >>>> This patch adds mt8196 dsp document. The dsp is used for Sound >>>> Open >>> >>> Please do not use "This commit/patch/change", but imperative mood. >>> See >>> longer explanation here: >>> > https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst*L95__;Iw!!CTRNKA9wMg0ARbw!g39q48fUCsDJ5PETUtQ0PK0Bkwf0Ce1F_ZzJiEiWMzuybWQ0dSPzblvLlJ-4saWTSoJWuS5imsXbpdgLBvUy4wxw9C5w7B4m$ >>> Fix your email client not to produce such junk like above ^. >>>> Firmware driver node. It includes registers, clocks, memory >>>> regions, >>>> and mailbox for dsp. >>>> >>>> Signed-off-by: Hailong Fan >>>> --- >>>> .../bindings/sound/mediatek,mt8196-dsp.yaml | 95 >>>> +++++++++++++++++++ >>>> 1 file changed, 95 insertions(+) >>>> create mode 100644 >>>> Documentation/devicetree/bindings/sound/mediatek,mt8196-dsp.yaml >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/sound/mediatek,mt8196- >>>> dsp.yaml >>>> b/Documentation/devicetree/bindings/sound/mediatek,mt8196- >>>> dsp.yaml >>>> new file mode 100644 >>>> index 000000000000..68f594f476e8 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8196- >>>> dsp.yaml >> >> Wrong folder; this should go to dsp/mediatek,mt8196-dsp.yaml .... >> >> ...but then I don't get why MT8196 wasn't simply added to >> mediatek,mt8186-dsp.yaml. >> > Yes, the first version was written this way, but the maintainer > suggested the following, so I'm not sure which approach is more > appropriate. Could you please provide a final recommendation? > > v1 link: > https://lore.kernel.org/all/a72988212d0d95bfe76eb9c53bbdb8c57c989377.camel@mediatek.com/ You linked to your reply. What does it prove? You are the maintainer and you gave this recommendation for your own patch? > > comment: >> >>> --- >>> .../bindings/dsp/mediatek,mt8196-dsp.yaml | 96 >>> +++++++++++++++++++ >> >> Don't grow dsp directory. Either this is remoteproc or some sound >> component, so place it accordingly. > This is a reference to the approach used in a previous MediaTek > project: > > > https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/dsp > Do we need to move all the files under the DSP directory to the sound > directory? No. Best regards, Krzysztof