From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: David Lechner <dlechner@baylibre.com>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Wenbin Mei <wenbin.mei@mediatek.com>
Cc: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: mmc: mtk-sd: add mediatek,mt8183-mmc fallback to mediatek,mt8189-mmc
Date: Fri, 20 Mar 2026 09:27:43 +0100 [thread overview]
Message-ID: <fa4d8347-e662-485b-b2b7-278a469176e8@collabora.com> (raw)
In-Reply-To: <20260319-mtk-mmc-mt8189-compatible-v1-1-fb7ef2186c92@baylibre.com>
Il 19/03/26 21:36, David Lechner ha scritto:
> Change mediatek,mt8189-mmc to include mediatek,mt8183-mmc as a fallback
> compatible.
>
> This has been tested using U-Boot and the MMC is still working using the
> mediatek,mt8183-mmc fallback compatible, so they seem to be compatible
> enough. And there are no upstream users of mediatek,mt8189-mmc yet, so
> this should not be a breaking change.
Devicetree describes hardware. This hardware IP is *not* compatible with the one
found in MT8183, as it is a different revision.
Luck wants that there weren't too many breaking changes, and that whatever does
change may need some more bits to activate before breaking, but describing this
as compatible with MT8183 is wrong, because ... it's not.
Sorry, but... NACK.
Regards,
Angelo
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index eb3755bdfdf7..9160e449aeb9 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -25,7 +25,6 @@ properties:
> - mediatek,mt8135-mmc
> - mediatek,mt8173-mmc
> - mediatek,mt8183-mmc
> - - mediatek,mt8189-mmc
> - mediatek,mt8196-mmc
> - mediatek,mt8516-mmc
> - items:
> @@ -36,6 +35,7 @@ properties:
> - mediatek,mt6893-mmc
> - mediatek,mt8186-mmc
> - mediatek,mt8188-mmc
> + - mediatek,mt8189-mmc
> - mediatek,mt8192-mmc
> - mediatek,mt8195-mmc
> - mediatek,mt8365-mmc
>
> ---
> base-commit: b84a0ebe421ca56995ff78b66307667b62b3a900
> change-id: 20260319-mtk-mmc-mt8189-compatible-a62da7c5dd7e
>
> Best regards,
> --
> David Lechner <dlechner@baylibre.com>
>
prev parent reply other threads:[~2026-03-20 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 20:36 [PATCH] dt-bindings: mmc: mtk-sd: add mediatek,mt8183-mmc fallback to mediatek,mt8189-mmc David Lechner
2026-03-20 8:27 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa4d8347-e662-485b-b2b7-278a469176e8@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=chaotian.jing@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox