Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Wenbin Mei <wenbin.mei@mediatek.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Chun-Hung Wu <chun-hung.wu@mediatek.com>,
	Yong Mao <yong.mao@mediatek.com>, <linux-mmc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	 <srv_heupstream@mediatek.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH] mmc: mediatek: move cqhci init behind ungate clock
Date: Thu, 28 Oct 2021 13:54:12 +0800	[thread overview]
Message-ID: <facef42345435d82600aca87d9b020fa073506ce.camel@mediatek.com> (raw)
In-Reply-To: <20211028022049.22129-1-wenbin.mei@mediatek.com>

On Thu, 2021-10-28 at 10:20 +0800, Wenbin Mei wrote:
> We must enable clock before cqhci init, because crypto needs
> read information from CQHCI registers, otherwise, it will hang
> in MediaTek mmc host controller.
> 
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
  Acked-by: Chaotian Jing <chaotian.jing@mediatek.com>
> Fixes: 88bd652b3c74 ("mmc: mediatek: command queue support")
> Cc: stable@vger.kernel.org
> ---
>  drivers/mmc/host/mtk-sd.c | 38 +++++++++++++++++++----------------
> ---
>  1 file changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index b124cfee05a1..943940b44e83 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2656,6 +2656,25 @@ static int msdc_drv_probe(struct
> platform_device *pdev)
>  		host->dma_mask = DMA_BIT_MASK(32);
>  	mmc_dev(mmc)->dma_mask = &host->dma_mask;
>  
> +	host->timeout_clks = 3 * 1048576;
> +	host->dma.gpd = dma_alloc_coherent(&pdev->dev,
> +				2 * sizeof(struct mt_gpdma_desc),
> +				&host->dma.gpd_addr, GFP_KERNEL);
> +	host->dma.bd = dma_alloc_coherent(&pdev->dev,
> +				MAX_BD_NUM * sizeof(struct
> mt_bdma_desc),
> +				&host->dma.bd_addr, GFP_KERNEL);
> +	if (!host->dma.gpd || !host->dma.bd) {
> +		ret = -ENOMEM;
> +		goto release_mem;
> +	}
> +	msdc_init_gpd_bd(host, &host->dma);
> +	INIT_DELAYED_WORK(&host->req_timeout, msdc_request_timeout);
> +	spin_lock_init(&host->lock);
> +
> +	platform_set_drvdata(pdev, mmc);
> +	msdc_ungate_clock(host);
> +	msdc_init_hw(host);
> +
>  	if (mmc->caps2 & MMC_CAP2_CQE) {
>  		host->cq_host = devm_kzalloc(mmc->parent,
>  					     sizeof(*host->cq_host),
> @@ -2676,25 +2695,6 @@ static int msdc_drv_probe(struct
> platform_device *pdev)
>  		mmc->max_seg_size = 64 * 1024;
>  	}
>  
> -	host->timeout_clks = 3 * 1048576;
> -	host->dma.gpd = dma_alloc_coherent(&pdev->dev,
> -				2 * sizeof(struct mt_gpdma_desc),
> -				&host->dma.gpd_addr, GFP_KERNEL);
> -	host->dma.bd = dma_alloc_coherent(&pdev->dev,
> -				MAX_BD_NUM * sizeof(struct
> mt_bdma_desc),
> -				&host->dma.bd_addr, GFP_KERNEL);
> -	if (!host->dma.gpd || !host->dma.bd) {
> -		ret = -ENOMEM;
> -		goto release_mem;
> -	}
> -	msdc_init_gpd_bd(host, &host->dma);
> -	INIT_DELAYED_WORK(&host->req_timeout, msdc_request_timeout);
> -	spin_lock_init(&host->lock);
> -
> -	platform_set_drvdata(pdev, mmc);
> -	msdc_ungate_clock(host);
> -	msdc_init_hw(host);
> -
>  	ret = devm_request_irq(&pdev->dev, host->irq, msdc_irq,
>  			       IRQF_TRIGGER_NONE, pdev->name, host);
>  	if (ret)
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2021-10-28  5:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28  2:20 [PATCH] mmc: mediatek: move cqhci init behind ungate clock Wenbin Mei
2021-10-28  5:54 ` Chaotian Jing [this message]
2021-10-28 10:00 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=facef42345435d82600aca87d9b020fa073506ce.camel@mediatek.com \
    --to=chaotian.jing@mediatek.com \
    --cc=chun-hung.wu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=stable@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wenbin.mei@mediatek.com \
    --cc=yong.mao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox