From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57517CA0EEB for ; Sun, 24 Aug 2025 19:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6yqEEUlIDSc/+3KFB8fDmfBaOKciQCNwulQzIyyj/3k=; b=CG6ALisLBkhxEYgTQKYC9ExP6K x+DoZWarBlu9Cq1cvqlCH9/QRQga5sReKy3GFR/tppvxI99Uc3IfvXxQqUZnWoPJsWHljmamDpPlm ecItLWTcy0UW8syHg87RTNmT7+yMbRhjdhSV0qf8uzxk9xdZdpgavw5aQr/N1iB9lfMIOIQATtqT6 qDzX4ldCi8Qs8EePo9MIb1Q+gLWipMrK2GM2EKQakynsO0MBSHYq3ae0r7R38/Azm8jav7kBbT2LY tPWQaKNg3fFk6ZL09PrUWX3A6qhc/tPiLimmif27YFytMwtCjlvAdf5bM00BRO7CnW76ACoXhZa4J 5bQptzaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqG1S-00000006Tgu-2z2p; Sun, 24 Aug 2025 19:04:58 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqG1K-00000006Tef-2SyQ for linux-mediatek@lists.infradead.org; Sun, 24 Aug 2025 19:04:53 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-55ce5095c90so347772e87.0 for ; Sun, 24 Aug 2025 12:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756062288; x=1756667088; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=6yqEEUlIDSc/+3KFB8fDmfBaOKciQCNwulQzIyyj/3k=; b=sN9NqbPDz9VzRdszVp/gpv3jGWU9Hle/9Gc2cxINzwQ0k1KSi64tSQopUVRVd5sgTC nFuuoaWI8HgcZpM+F4JfMk7mOAlL4bbYo6E6iQ406ElxOcyu8lzHEHZKeppkF6o6EVWj 6Tgiyupg3Ly/ya5MmpLwmUmtKxAereZgF0PyoIEMlag1dr0kEhtHz4QIWfdb+Md6WmF8 av9kqFzaFfv5qtAkDuHP8bLetkBuncRe5zti6vyTUlabtzMXz8td06c5+TDd+HReEwxZ YtOMZNiZEcuRXry87otSW7R8bAxtn6cFwUPv9Zy86RtXcLrnJjww/+X/niNPcALdZa7/ 1/ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756062288; x=1756667088; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6yqEEUlIDSc/+3KFB8fDmfBaOKciQCNwulQzIyyj/3k=; b=JlbGzt2PowM2gEbOJ6gidm1BevzradNIAQz/0bCJWmHUYnqf/SUB7IXQM45s441r4E Bf3jxwRnDZ4riV+lEkx/8Svbn+CDcZXV8217vSJJJcGO3WfKMkU0JWyXm8ejTymY/zO8 LrSyJ6PCEksrh/kLFo+ctfyp4sGBirlPDaCk810s4EFd2DuSUvw25cqefLRWRdzAcnUi tfZCjPkDMZkh1ddzrh1GhLppthSR8d/s39kU+cL/vr2rULMTGwVYWEE1DUtlz3J1PZtz zkFc2ntCWhmUfTd04XMiopv0mmBNXW1/DxbylhbIpjXG1X7FXKzhP72I4DATxeSX6+a7 ofzw== X-Forwarded-Encrypted: i=1; AJvYcCVYNsAxIHc2J2jgmRNIIJnLmuDSoknzlUzU0Lre+kN8TftbyyHpWS64bB0sA1aFRKis81WqzDBtNSN2700FEw==@lists.infradead.org X-Gm-Message-State: AOJu0Yw83XpOrJ7UtQrRWKM+k8Xf9z+jC6KTM5MXb+3qxkD+djyWv25L G0S1V6Tkd9IqnZ6UKRYq/7A57SIegY2jXVEp+6WmOLi8hBYatKXdH2oFjsoq5ojV48M= X-Gm-Gg: ASbGncuF38s+3nArgFvGvCTy0sm3PmCwwCpt3xt3xoiSifmfGLCOmkjVClQJKlVxe8h Kj1gX88thaxHf4Pb2nHR4n1Q5qK59/og4/tz+0sXtuu6V8kA2PXgCGJxBIISoSofiDw4sLehJ0P lNUfRUlJcRKH9WuTmqamL5/yCGo56boONWxIqZ36OrdyOTrKmHXwfYnkT5dVYLDz07eNNUH39Sk xbPwZsJBbuX+Q0+k6MITWUyYIUmrAQVpdWCxsPZYY+hI/AZB8QPmvU6pq4f7YzyHs7/peBMNqf2 2j9EUQrpVH9Zf0eA5UpIwU0KLBGIygwoL8SYpR2iu9/YejXtAPG0wZTy9V4bMyYtAPdV3/XcI4N 837Tx7POWVmCwc8qc/utLV9HKVsmWEA3zjtxlv6qgoS6nwjxZQDSWXjLFyCzpy7COr+kVK8oKlQ eL X-Google-Smtp-Source: AGHT+IFyrm2w79r4qu/FnmHu4qBJdoxQ8tpCUb7HA7mtPlKxjeyzi9xJQ9J7AuBmZ4uek0zzq2ON9Q== X-Received: by 2002:a05:6512:a85:b0:553:24b4:6492 with SMTP id 2adb3069b0e04-55f0cd6ef0bmr1246189e87.5.1756062288277; Sun, 24 Aug 2025 12:04:48 -0700 (PDT) Received: from [192.168.1.100] (88-112-128-43.elisa-laajakaista.fi. [88.112.128.43]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55f35c8bb4esm1204996e87.75.2025.08.24.12.04.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Aug 2025 12:04:47 -0700 (PDT) Message-ID: Date: Sun, 24 Aug 2025 22:04:45 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 19/65] media: camss: Replace .open() file operation with v4l2_fh_open() To: Jacopo Mondi , Mauro Carvalho Chehab , Devarsh Thakkar , Benoit Parrot , Hans Verkuil , Laurent Pinchart , Hans de Goede , Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman , Alex Shi , Yanteng Si , Jonathan Corbet , Tomasz Figa , Marek Szyprowski , Andy Walls , Michael Tretter , Pengutronix Kernel Team , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Mirela Rabulea , Shawn Guo , Sascha Hauer , Fabio Estevam , Kieran Bingham , Michal Simek , Ming Qian , Zhou Peng , Xavier Roumegue , Philipp Zabel , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Sylwester Nawrocki , Jernej Skrabec , Chen-Yu Tsai , Samuel Holland , Daniel Almeida , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Tiffany Lin , Yunfei Dong , Geert Uytterhoeven , Magnus Damm , Mikhail Ulyanov , Jacob Chen , Heiko Stuebner , Detlev Casanova , Krzysztof Kozlowski , Sylwester Nawrocki , =?UTF-8?Q?=C5=81ukasz_Stelmach?= , Andrzej Pietrasiewicz , Jacek Anaszewski , Andrzej Hajda , Fabien Dessenne , Jean-Christophe Trotin , Maxime Coquelin , Alexandre Torgue , Nicolas Dufresne , Benjamin Gaignard , Steve Longerbeam , Maxime Ripard , Paul Kocialkowski , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Robert Foss , Todor Tomov , Corentin Labbe , Sakari Ailus , Stanislaw Gruszka Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, mjpeg-users@lists.sourceforge.net References: <20250802-media-private-data-v1-0-eb140ddd6a9d@ideasonboard.com> <20250802-media-private-data-v1-19-eb140ddd6a9d@ideasonboard.com> From: Vladimir Zapolskiy In-Reply-To: <20250802-media-private-data-v1-19-eb140ddd6a9d@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250824_120450_678231_85220AE2 X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Jacopo, Laurent, thank you for the nice clean-up. On 8/2/25 12:22, Jacopo Mondi wrote: > From: Laurent Pinchart > > The custom video_open() function in the camss driver open-codes the > v4l2_fh_open() helper, with an additional mutex that protects the whole > function. Given that the function does not modify any data guarded by > the lock, there's no need for using the mutex and the function can be > replaced by v4l2_fh_open(). > > Signed-off-by: Laurent Pinchart > Signed-off-by: Jacopo Mondi Tested-by: Vladimir Zapolskiy Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir