[PATCH 0/3] Migrate MT8188 VPPSYS 0/1 to mtk-mmsys driver

[PATCH 0/3] Migrate MT8188 VPPSYS 0/1 to mtk-mmsys driver

[yu-chang.lee]

Hi,

This series is to reflect VPPSYS' dependency on mtk-mmsys driver for
mediatek MT8188 platform. The MT8188 VPPSYS 0/1 should be probed 
from the "mtk-mmsys" driver, which then starts its own clock driver
as the platform driver.

Refer to the suggestion in the following patch
https://patchwork.kernel.org/project/linux-mediatek/list/?series=796808
https://patchwork.kernel.org/project/linux-mediatek/list/?series=798392

yu-chang.lee (3):
  soc: mediatek: mmsys: Add support for MT8188 VPPSYS
  dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS
  dt-bindings: arm:mediatek: mmsys: Add VPPSYS compatible for MT8188

 .../bindings/arm/mediatek/mediatek,mmsys.yaml        |  2 ++
 .../bindings/clock/mediatek,mt8188-clock.yaml        |  2 --
 drivers/soc/mediatek/mtk-mmsys.c                     | 12 ++++++++++++
 3 files changed, 14 insertions(+), 2 deletions(-)

-- 
2.18.0

[PATCH 1/3] soc: mediatek: mmsys: Add support for MT8188 VPPSYS

[yu-chang.lee]

Add MT8188 VPPSYS0 and VPPSYS1 driver data.

Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
---
 drivers/soc/mediatek/mtk-mmsys.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
index 88209102ff3b..1e5239cc5445 100644
--- a/drivers/soc/mediatek/mtk-mmsys.c
+++ b/drivers/soc/mediatek/mtk-mmsys.c
@@ -89,6 +89,16 @@ static const struct mtk_mmsys_driver_data mt8188_vdosys0_driver_data = {
 	.num_routes = ARRAY_SIZE(mmsys_mt8188_routing_table),
 };
 
+static const struct mtk_mmsys_driver_data mt8188_vppsys0_driver_data = {
+	.clk_driver = "clk-mt8188-vpp0",
+	.is_vppsys = true,
+};
+
+static const struct mtk_mmsys_driver_data mt8188_vppsys1_driver_data = {
+	.clk_driver = "clk-mt8188-vpp1",
+	.is_vppsys = true,
+};
+
 static const struct mtk_mmsys_driver_data mt8192_mmsys_driver_data = {
 	.clk_driver = "clk-mt8192-mm",
 	.routes = mmsys_mt8192_routing_table,
@@ -429,6 +439,8 @@ static const struct of_device_id of_match_mtk_mmsys[] = {
 	{ .compatible = "mediatek,mt8183-mmsys", .data = &mt8183_mmsys_driver_data },
 	{ .compatible = "mediatek,mt8186-mmsys", .data = &mt8186_mmsys_driver_data },
 	{ .compatible = "mediatek,mt8188-vdosys0", .data = &mt8188_vdosys0_driver_data },
+	{ .compatible = "mediatek,mt8188-vppsys0", .data = &mt8188_vppsys0_driver_data },
+	{ .compatible = "mediatek,mt8188-vppsys1", .data = &mt8188_vppsys1_driver_data },
 	{ .compatible = "mediatek,mt8192-mmsys", .data = &mt8192_mmsys_driver_data },
 	/* "mediatek,mt8195-mmsys" compatible is deprecated */
 	{ .compatible = "mediatek,mt8195-mmsys", .data = &mt8195_vdosys0_driver_data },
-- 
2.18.0

Re: [PATCH 1/3] soc: mediatek: mmsys: Add support for MT8188 VPPSYS

[AngeloGioacchino Del Regno]

Il 09/11/23 09:21, yu-chang.lee ha scritto:
> Add MT8188 VPPSYS0 and VPPSYS1 driver data.
> 
> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

[PATCH 2/3] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS

[yu-chang.lee]

Remove VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.

Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
---
 .../devicetree/bindings/clock/mediatek,mt8188-clock.yaml        | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
index d7214d97b2ba..860570320545 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
@@ -43,8 +43,6 @@ properties:
       - mediatek,mt8188-vdecsys
       - mediatek,mt8188-vdecsys-soc
       - mediatek,mt8188-vencsys
-      - mediatek,mt8188-vppsys0
-      - mediatek,mt8188-vppsys1
       - mediatek,mt8188-wpesys
       - mediatek,mt8188-wpesys-vpp0
 
-- 
2.18.0

Re: [PATCH 2/3] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS

[AngeloGioacchino Del Regno]

Il 09/11/23 09:22, yu-chang.lee ha scritto:
> Remove VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.
> 
> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>

The mail recipients are wrong/incomplete. This patch cannot ever possibly get
upstream if you don't Cc the right people/lists.

Please use scripts/get_maintainer.pl to get the right list of recipients and
resend.

Thanks,
Angelo

> ---
>   .../devicetree/bindings/clock/mediatek,mt8188-clock.yaml        | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
> index d7214d97b2ba..860570320545 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
> @@ -43,8 +43,6 @@ properties:
>         - mediatek,mt8188-vdecsys
>         - mediatek,mt8188-vdecsys-soc
>         - mediatek,mt8188-vencsys
> -      - mediatek,mt8188-vppsys0
> -      - mediatek,mt8188-vppsys1
>         - mediatek,mt8188-wpesys
>         - mediatek,mt8188-wpesys-vpp0
>   

Re: [PATCH 2/3] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS

[Yu-chang Lee (李禹璋)]

On Thu, 2023-11-09 at 10:15 +0100, AngeloGioacchino Del Regno wrote:
> Il 09/11/23 09:22, yu-chang.lee ha scritto:
> > Remove VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.
> > 
> > Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
> 
> The mail recipients are wrong/incomplete. This patch cannot ever
> possibly get
> upstream if you don't Cc the right people/lists.
> 
> Please use scripts/get_maintainer.pl to get the right list of
> recipients and
> resend.
> 
> Thanks,
> Angelo
> 
Thank for your time and patience, I already resend the same series with
list script provided.

Thanks

Best Regards,
Yu Chang

> > ---
> >   .../devicetree/bindings/clock/mediatek,mt8188-clock.yaml        | 
> > 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/clock/mediatek,mt8188-
> > clock.yaml
> > b/Documentation/devicetree/bindings/clock/mediatek,mt8188-
> > clock.yaml
> > index d7214d97b2ba..860570320545 100644
> > --- a/Documentation/devicetree/bindings/clock/mediatek,mt8188-
> > clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8188-
> > clock.yaml
> > @@ -43,8 +43,6 @@ properties:
> >         - mediatek,mt8188-vdecsys
> >         - mediatek,mt8188-vdecsys-soc
> >         - mediatek,mt8188-vencsys
> > -      - mediatek,mt8188-vppsys0
> > -      - mediatek,mt8188-vppsys1
> >         - mediatek,mt8188-wpesys
> >         - mediatek,mt8188-wpesys-vpp0
> >   
> 
> 

Re: [PATCH 2/3] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS

[Krzysztof Kozlowski]

On 09/11/2023 12:14, Yu-chang Lee (李禹璋) wrote:
> On Thu, 2023-11-09 at 10:15 +0100, AngeloGioacchino Del Regno wrote:
>> Il 09/11/23 09:22, yu-chang.lee ha scritto:
>>> Remove VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.
>>>
>>> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
>>
>> The mail recipients are wrong/incomplete. This patch cannot ever
>> possibly get
>> upstream if you don't Cc the right people/lists.
>>
>> Please use scripts/get_maintainer.pl to get the right list of
>> recipients and
>> resend.
>>
>> Thanks,
>> Angelo
>>
> Thank for your time and patience, I already resend the same series with
> list script provided.

Oh, really? Please point me to this submission where you Cc all
maintainers presented by get_maintainer.pl.

Best regards,
Krzysztof

Re: [PATCH 2/3] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS

[Krzysztof Kozlowski]

On 09/11/2023 09:22, yu-chang.lee wrote:
> Remove VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.
> 
> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof

[PATCH 3/3] dt-bindings: arm:mediatek: mmsys: Add VPPSYS compatible for MT8188

[yu-chang.lee]

Add VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.

Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
---
 .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml        | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
index 536f5a5ebd24..50324248b965 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
@@ -32,6 +32,8 @@ properties:
               - mediatek,mt8183-mmsys
               - mediatek,mt8186-mmsys
               - mediatek,mt8188-vdosys0
+              - mediatek,mt8188-vppsys0
+              - mediatek,mt8188-vppsys1
               - mediatek,mt8192-mmsys
               - mediatek,mt8195-vdosys1
               - mediatek,mt8195-vppsys0
-- 
2.18.0

Re: [PATCH 3/3] dt-bindings: arm:mediatek: mmsys: Add VPPSYS compatible for MT8188

[Krzysztof Kozlowski]

On 09/11/2023 09:22, yu-chang.lee wrote:
> Add VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.
> 
> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof