From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9C69C001DE for ; Mon, 31 Jul 2023 10:45:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gL1l2j16R8FEzSmXM55q4q/nwDSDduGxi6Q27mgjPxQ=; b=QHPEO59DarpH+zOjRJBP4ffBFg mPVFyyrGKQs7lKnTHimA24izuqXJlmd+OWQPjM3KFtfOthbxs+l3tAR0EiUmh8pZ4LUCAnFpdKlQM OV14++1IrrU/VN3u2LuAW9qIdRhvdbwFfTp8tuQXOnFO+WkV4oqGhEO6RqVNdJoese6jz9sx/IELZ 8oQwD/LKlVTbmOz8x28DIvgRJnqLYkGBwz2ukEmlfoMmck2dqgp9KcIsNOG4tY5mcF7rHNC8fS/6F 7nQQYw98O3sN57opZrzt7b3YoxQThsZqpw0p1ocPh0f+3aiDTVM/GNJUBiK4OJ7vVklW7TeSbTtBN /mCwU5Fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQQOg-00F8nv-31; Mon, 31 Jul 2023 10:45:06 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQQOd-00F8mM-0T; Mon, 31 Jul 2023 10:45:04 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2B4106606EF9; Mon, 31 Jul 2023 11:45:01 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690800302; bh=/xy20Cx4V6EcMmCM8zDIAQr6l+aYKGfHtIlKmzg8S3o=; h=Date:Subject:To:References:From:In-Reply-To:From; b=kH/YeZhuGKaOtHqLEoRX/qQ2/e9rZ3Jpmfi9GcY3R2995jNbEbKVZNs/UqnReqGu2 ZylGZdK8yb8QsXtB7Y9/rJjINZBL/056DWM1UZBL6KTZlWt23VcctporE2HHOURKSi EABlVob6ZwWjO92I4tZkaDXN5YJaBNTVCZgwU0x93VUzmRWLo0xI+nqPOcOz052+lh NPi0RsiUYDXKeSTpCE2ePfHEXRxuyjXP68dPEAzT2oKn2ZyUrkg+TFfhsTJdaQzSYv q53//+H1ZZ4GdwywQjETz+n9DH+zSqAFm3o7ZTfRMDyssICFVBePj7hTQq/5M4GvfD eOSJmovLnmX3w== Message-ID: Date: Mon, 31 Jul 2023 12:44:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 5/6] ASoC: dt-bindings: mediatek,mt7986-wm8960: add mt7986-wm8960 document Content-Language: en-US To: =?UTF-8?B?TWFzbyBIdWFuZyAo6buD5Yqg56u5KQ==?= , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "chenxiangrui@huaqin.corp-partner.google.com" , =?UTF-8?B?VHJldm9yIFd1ICjlkLPmlofoia8p?= , "devicetree@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?QWxsZW4tS0ggQ2hlbmcgKOeoi+WGoOWLsik=?= , "broonie@kernel.org" , "conor+dt@kernel.org" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "perex@perex.cz" , "arnd@arndb.de" , "alsa-devel@alsa-project.org" References: <20230728090819.18038-1-maso.huang@mediatek.com> <20230728090819.18038-6-maso.huang@mediatek.com> <8e207baf-4a85-71f1-8ea3-08eab438b7cd@collabora.com> <4aa7dd33239d568cfdf46f1e403bdeeef947726a.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <4aa7dd33239d568cfdf46f1e403bdeeef947726a.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230731_034503_316343_6CBCFDC2 X-CRM114-Status: GOOD ( 16.93 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 31/07/23 08:42, Maso Huang (黃加竹) ha scritto: > On Fri, 2023-07-28 at 18:16 +0800, Maso Huang wrote: >> On Fri, 2023-07-28 at 11:55 +0200, AngeloGioacchino Del Regno wrote: >>> Il 28/07/23 11:08, Maso Huang ha scritto: >>>> Add document for mt7986 board with wm8960. >>>> >>>> Signed-off-by: Maso Huang >>>> --- >>>> .../sound/mediatek,mt7986-wm8960.yaml | 53 >>>> +++++++++++++++++++ >>>> 1 file changed, 53 insertions(+) >>>> create mode 100644 >>>> Documentation/devicetree/bindings/sound/mediatek,mt7986- >>>> wm8960.yaml >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/sound/mediatek,mt7986- >>>> wm8960.yaml >>>> b/Documentation/devicetree/bindings/sound/mediatek,mt7986- >>>> wm8960.yaml >>>> new file mode 100644 >>>> index 000000000000..76394f7e5502 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt7986- >>>> wm8960.yaml >>>> @@ -0,0 +1,53 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: >>>> > https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mediatek,mt7986-wm8960.yaml*__;Iw!!CTRNKA9wMg0ARbw!lu4Z6pJeRiL7-8l4T3ptqUCM54FnHTBiyh5KWBNqSjl6mOOI7WmzHpWEd-ZSZ-2NJ4Cs9PPaAF_75ywo2SKW16MPPRaROt0$ >>>> >>>> >>>> +$schema: >>>> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!lu4Z6pJeRiL7-8l4T3ptqUCM54FnHTBiyh5KWBNqSjl6mOOI7WmzHpWEd-ZSZ-2NJ4Cs9PPaAF_75ywo2SKW16MPttZILAo$ >>>> >>>> >>>> + >>>> +title: MediaTek MT7986 sound card with WM8960 codec >>>> + >>>> +maintainers: >>>> + - Maso Huang >>>> + >>>> +properties: >>>> + compatible: >>>> + const: mediatek,mt7986-wm8960-machine >>> >>> mediatek,mt7986-wm8960-sound looks better. >>> >>> After which, >>> >>> Reviewed-by: AngeloGioacchino Del Regno < >>> angelogioacchino.delregno@collabora.com> >>> >>> >> >> Hi Angelo, >> >> Thanks for your review. >> I'll change the compatible to "mediatek,mt7986-wm8960-sound" in v4 >> patch. >> >> Best regards, >> Maso >> > > Hi Angelo, > > One more question for this compatible. > > The suffix "machine" means alsa machine driver for mt7986-wm8960. It > might be better to use "machine" here. > > Or you prefer "sound" than "machine"? > > Best regards, > Maso I prefer "sound" because of consistency with other MediaTek machine driver compatible strings. Regards, Angelo