From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9E6DC44506 for ; Thu, 9 Jul 2026 14:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c1KoFQZlVh0TW1NBILxP1YmKzlfNH0nOR4JY+OmiGCQ=; b=D5TjBOLFctCyarQ+SgD2prlQ/b 65KQcv778dYrb610D92E1Aenixb7mcEdOUqB0RXMTR3Qvx6+uqLB7ub24iDhpTi0r2s/K3YLD4188 bD3DQlS5nZ4YeFnaCk/u5Nn7rxSfivfQA3W1VjDfdITB9LwR3y0II8DI3/j5R8g57kIbi8iKYdtAj 7N0i/CKHN25jSM1Vh9fkhg9/JulD+0idv86KLgMreK7nkafpfH93cb9F0DGzTX7Kp9kCY9t/Nc2Jv agzh+vwLsKL7w5LPzGQK11ttNrkkfnJIBY89PTr2saztbifH4BK7g6WDtwO2swB/b2lxkzUkeMNB2 7qKuzbvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whpKB-00000002gmE-3QVw; Thu, 09 Jul 2026 14:01:59 +0000 Received: from bali.collaboradmins.com ([2a01:4f8:201:9162::2]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whpK5-00000002gfJ-3ZBD; Thu, 09 Jul 2026 14:01:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1783605710; bh=8SkAR/Ab8XsPGdgW8BYCG02vOqkW8k+veVBNwe9Ul5c=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eZ+WEEEtNdm44adPY3hOzL/+043uJYdbKHMRPcOv/18YBSEdZMoRnvyyqIL8/9Zt5 8fs7GrdxwcKJgwbDNyUcMYbBkx+ZhCs0ij/p1PX0UeHb8IPLBcNL8lTEr7vLCq+DVO TTRNPt+MsiNJ6E+tfrSZPcAh9pn8TGJqfm1uiz71RYzV9ajbnG8D7furdXlRu9ovaX clxJ/Z1QYFaE+9JVTpbx7GrjX1Vp74T6aexce8p5OinZoYqF/3i8vRFiSP4gvaj+T7 EzW3N7xkMs+JUCu6VOneil+AMeXom/GfEu89VRtlJGLFu0YRKjHX/WqNgzYiJ7TqEO A3O8/cowCQsNw== Received: from [100.64.1.21] (unknown [100.64.1.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7569317E0D56; Thu, 09 Jul 2026 16:01:49 +0200 (CEST) Message-ID: Date: Thu, 9 Jul 2026 16:01:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/18] dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8186 To: Louis-Alexis Eyraud , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Chun-Jie Chen , Philipp Zabel , Edward-JW Yang , Richard Cochran Cc: kernel@collabora.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org References: <20260709-mt8189-clocks-system-base-v2-0-2926da3db6cf@collabora.com> <20260709-mt8189-clocks-system-base-v2-1-2926da3db6cf@collabora.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20260709-mt8189-clocks-system-base-v2-1-2926da3db6cf@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_070154_902591_61EEF4BB X-CRM114-Status: UNSURE ( 7.13 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 7/9/26 15:42, Louis-Alexis Eyraud wrote: > Both MT8186 clock controllers dt-bindings (clock and sys-clock) > document the '#clock-cells' property but do not enforce it as required > property. > As clock provider nodes should define this property in devicetrees, add > it to the required property list in both its dt-bindings files. > > Signed-off-by: Louis-Alexis Eyraud Though you could've done that in one commit, or just skipped the additions in all of mt8186/92/95 and went directly for the new one... IMO, it's ok as you're showing that there was an actual mistake on the bindings for clock controllers. Same comment applies for patch 2 and 3, btw. Anyway: Reviewed-by: AngeloGioacchino Del Regno