From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F1EECCF2C9 for ; Sun, 18 Oct 2026 05:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OZY9wh4sxQs63RQAxeF2tIFILu93inTX2QwnrPUnhYs=; b=GN1VcgLwyjUAADCTEFg08xHmJB 5Eiy8MjdWkxNopAWkqb9FLYz9gfYhdBJC76Fz9txD96cCsRttROQnjlwpzL64UeDTrFJ7AgRvmWd0 IhZkcQ+v7I4NHokfLcjP3LeEJegQujQNnAQdpCyXJJYcnds98u64s6YE+Cc9G/AkttwrKE/ALDYCh +SE2a5Q4ElfOtXSc/jRnEwm6EZrmdOxpke+1hWdPevh4/iMXGltr63iJ+n1/9im66vVrRJKfGkpIj lnfwJVB30F45/ujGcHw3fjWgqabM4/ru9liRoRxySa/Rf62nVM7NmoLTsJce7oRHYrrkxQ63OsCLe wiZzIQrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIJkd-00000005Z9p-2xSt; Sun, 18 Oct 2026 05:48:08 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIJka-00000005Z8p-0djy for linux-mediatek@lists.infradead.org; Sun, 18 Oct 2026 05:48:06 +0000 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-8a05b210703so153039b3a.0 for ; Sat, 17 Oct 2026 22:48:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792302483; x=1792907283; darn=lists.infradead.org; h=content-type:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=OZY9wh4sxQs63RQAxeF2tIFILu93inTX2QwnrPUnhYs=; b=eTDxHS/IsQI8ik0DlAq43UF7i2CxOIEPQ/Orw/3hsrzBdU8Usw72p3JB85+hRwfVQt lC7rvFMrFUQKy38Hwh4oaRHfSBQQRe4kF/emAqvUic65g2niRhD2IPha9SXow1zkGABZ 8bw/2GZ7v47kdT+oBRbMKHcveKO/2XDPho7GF8SBolFUgAkpegUCAiWOOasNqnvF6U+o 4JccNbKYMODkNDienJl7aZdmxux5dnSC1cK/ojelk+wc1HzEYRwpP7gnX8s5e+B33gsD FxDQ/ek/etgbMfQlPbBeJcDcv48Cj+8CkOSGsgmYcsVHhdFlFOHQxLb9x07S+vPMJJkG qGIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792302483; x=1792907283; h=content-type:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OZY9wh4sxQs63RQAxeF2tIFILu93inTX2QwnrPUnhYs=; b=mxi7dt3QBWvH/BD7gIRXWqceykKKEAB3W+GsQXLYqAv3PEEflw7CfjpcD1Am5OqAyA /dY2Rl9hRP6SdGHFbiCo2u+CzFRVzWb2fTkjG7ZeMJqvppmlzcXQ7qo2KFeJT11Fdr6l 0mlBcZONmZqiUoYHhoFwfZKb4s/m++SWFjKEwBp+JszWMHhU5OhTWwnsYdVtiGE+Xnpr /gsr6CmqeMNmopTDgugli8YHZm7IxA/62InobsQfWbX4reQtKrKfXMIM2FpQ++Au37Ch mTX2v2pS9spZx/0qKdy7bXvx+mWg5DvGcJd1Jpjvyba3zlsefBtaetx9fxEMM7u6v8j8 hBDw== X-Forwarded-Encrypted: i=1; AKwUvBzHBHkLUPRZVXpKQLofbgGBQJ69rzB+jB7YOj2X85BQlCQd+sgg6GKdomM6Tvg9FE8mFZDyoKAgIk4F7jYueQ==@lists.infradead.org X-Gm-Message-State: AFq9FYKXXtvLSBDSYXl3ZpWnYNzOuJmrp5IJdEGLgUR41tNmRfIltje4 BKwQpZ/1AhFcMpdWRfL1euVrHDePXHekfBsL7R3ur0DtUiuWHdjbXOFi X-Gm-Gg: AYBFou1BtyW1eTpKRIEW+IvnThdOj8YrbO+kA0rdI/HiSEz7myaVBLIrh0cUYFxOZl3 yasREpA/alzh6tIZeiD54zUjJ9y2cOQHI2IBhC19CO/xBouh3eyVS2VlqiZ+4ThIrjSHoC8NIZS lwM3RVe1aoiPXZYvxGBh6M6Hi1AVKamVhsA4U9BcsS8e8ZtTjBBvDrgOnGc+A3ILW9jftFdxUxh ueaHCECLtVqCVdoF/9bpQnqKYDbNrcRVPCmMhZswy385fM1sYhR1nonuRA35+H4mpYidoF27KWO NeAqxOUEhDLvF6P8GuBK8oZaMOPY2Ij0st4Xh3RqN8/Pjp+SRJU0TRyW1+HC53dIvX96tv22mgs 0YsT41vZZ9gx02CLkISdQivgr3vOyC26WCf2RvNmt4xG0GzV1IAvFdk1dBLR1sc0ee2njsVRD0O 7im0YDzbam8Q8WXkLQoZGbvaM9UnZtraP/8tEIC5s3vc06tKchot1l6x+yq+WiQJGhd4l+eU6Fq c/U5M+akdWfkH/+PHwPB1VmG2FIMmpAqvgR2Ii2bD4t0dhQ0XL/hykKlplp/IAP4saoV41b1tx2 QX86/W1iM+0oaWbOToubwdVoMtqNEYtSkDHI+XQA7M6aD8cj1jk= X-Received: by 2002:a05:6a20:c5aa:b0:3e1:efce:1d35 with SMTP id adf61e73a8af0-3e225f2b40emr3593769637.14.1792302483139; Sat, 17 Oct 2026 22:48:03 -0700 (PDT) Received: from setsuna.localnet ([2403:581e:d87e:0:fc2d:ed31:e80e:412d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-89f57452b16sm2648102b3a.29.2026.10.17.22.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 22:48:02 -0700 (PDT) From: James Calligeros To: Charles Keepax Cc: David Rhodes , Richard Fitzgerald , Martin =?UTF-8?B?UG92acWhZXI=?= , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , AngeloGioacchino Del Regno , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Sven Peter , Janne Grunau , Neal Gompa , asahi@lists.linux.dev, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 08/21] ASoC: card: Let 'fixup_controls' return errors Date: Sun, 18 Oct 2026 15:47:54 +1000 Message-ID: In-Reply-To: References: <20261004-macaudio-v2-0-7b47ed6335a8@gmail.com> <20261004-macaudio-v2-8-7b47ed6335a8@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261017_224804_188556_ACBCE7D0 X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thursday, 8 October 2026 12:23:42=E2=80=AFam Australian Eastern Standard= Time=20 Charles Keepax wrote: > On Sun, Oct 04, 2026 at 04:03:35PM +1000, James Calligeros wrote: > > From: Martin Povi=C5=A1er > >=20 > > Let the 'fixup_controls' card method return error values which will roll > > back the half-done binding of the card. > >=20 > > Signed-off-by: Martin Povi=C5=A1er > > Signed-off-by: James Calligeros > > --- > >=20 > > include/sound/soc-card.h | 2 +- > > include/sound/soc.h | 2 +- > > .../soc/mediatek/mt8188/mt8188-mt6359.c | 4 +++- > > sound/soc/soc-card.c | 12 +++++++++--- > > sound/soc/soc-core.c | 5 ++++- >=20 > Fixup is missing here for sound/soc/sdca/sdca_class_function.c Unless I'm missing something, that one calls the .fixup_controls on snd_soc_component_driver, which is not the snd_soc_card callback modified by this commit. That callback already expected an int, and class_function_component_fixup_controls already returns one per b8f71f16134f ("ASoC: SDCA: Switch to fixup_controls callback for IRQ registration"). Regards, James