* [PATCH 1/1] scsi: ufs: Print real incorrect request response code
@ 2019-04-15 12:23 Stanley Chu
2019-04-15 13:51 ` Bart Van Assche
2019-04-16 2:18 ` Martin K. Petersen
0 siblings, 2 replies; 4+ messages in thread
From: Stanley Chu @ 2019-04-15 12:23 UTC (permalink / raw)
To: linux-scsi, martin.petersen, avri.altman, alim.akhtar,
pedrom.sousa
Cc: marc.w.gonzalez, andy.teng, chun-hung.wu, kuohong.wang, evgreen,
linux-mediatek, peter.wang, matthias.bgg, Stanley Chu,
linux-arm-kernel, beanhuo
If UFS device responds an unknown request response code,
we can not know what it was via logs because the code
is replaced by "DID_ERROR << 16" before log printing.
Fix this to provide precise request response code information
for easier issue breakdown.
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index e040f9dd9ff3..fbe1e88eec55 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4704,10 +4704,10 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
"Reject UPIU not fully implemented\n");
break;
default:
- result = DID_ERROR << 16;
dev_err(hba->dev,
"Unexpected request response code = %x\n",
result);
+ result = DID_ERROR << 16;
break;
}
break;
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] scsi: ufs: Print real incorrect request response code
2019-04-15 12:23 [PATCH 1/1] scsi: ufs: Print real incorrect request response code Stanley Chu
@ 2019-04-15 13:51 ` Bart Van Assche
2019-04-15 13:58 ` Winkler, Tomas
2019-04-16 2:18 ` Martin K. Petersen
1 sibling, 1 reply; 4+ messages in thread
From: Bart Van Assche @ 2019-04-15 13:51 UTC (permalink / raw)
To: Stanley Chu, linux-scsi, martin.petersen, avri.altman,
alim.akhtar, pedrom.sousa
Cc: marc.w.gonzalez, andy.teng, chun-hung.wu, kuohong.wang, evgreen,
linux-mediatek, peter.wang, matthias.bgg, linux-arm-kernel,
beanhuo
On 4/15/19 5:23 AM, Stanley Chu wrote:
> If UFS device responds an unknown request response code,
> we can not know what it was via logs because the code
> is replaced by "DID_ERROR << 16" before log printing.
>
> Fix this to provide precise request response code information
> for easier issue breakdown.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index e040f9dd9ff3..fbe1e88eec55 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4704,10 +4704,10 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
> "Reject UPIU not fully implemented\n");
> break;
> default:
> - result = DID_ERROR << 16;
> dev_err(hba->dev,
> "Unexpected request response code = %x\n",
> result);
> + result = DID_ERROR << 16;
> break;
> }
> break;
>
Should "Fixes:" and "Cc: stable" tags be added to this patch?
Thanks,
Bart.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/1] scsi: ufs: Print real incorrect request response code
2019-04-15 13:51 ` Bart Van Assche
@ 2019-04-15 13:58 ` Winkler, Tomas
0 siblings, 0 replies; 4+ messages in thread
From: Winkler, Tomas @ 2019-04-15 13:58 UTC (permalink / raw)
To: Bart Van Assche, Stanley Chu, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, avri.altman@wdc.com,
alim.akhtar@samsung.com, pedrom.sousa@synopsys.com
Cc: marc.w.gonzalez@free.fr, andy.teng@mediatek.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
evgreen@chromium.org, linux-mediatek@lists.infradead.org,
peter.wang@mediatek.com, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org, beanhuo@micron.com
> On 4/15/19 5:23 AM, Stanley Chu wrote:
> > If UFS device responds an unknown request response code, we can not
> > know what it was via logs because the code is replaced by "DID_ERROR
> > << 16" before log printing.
> >
> > Fix this to provide precise request response code information for
> > easier issue breakdown.
> >
> > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> > ---
> > drivers/scsi/ufs/ufshcd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index e040f9dd9ff3..fbe1e88eec55 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -4704,10 +4704,10 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba,
> struct ufshcd_lrb *lrbp)
> > "Reject UPIU not fully implemented\n");
> > break;
> > default:
> > - result = DID_ERROR << 16;
> > dev_err(hba->dev,
> > "Unexpected request response code = %x\n",
> > result);
> > + result = DID_ERROR << 16;
> > break;
> > }
> > break;
> >
>
> Should "Fixes:" and "Cc: stable" tags be added to this patch?
Doesn't look like a regression or a critical issue.
The patch looks good to me.
Thanks
Tomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] scsi: ufs: Print real incorrect request response code
2019-04-15 12:23 [PATCH 1/1] scsi: ufs: Print real incorrect request response code Stanley Chu
2019-04-15 13:51 ` Bart Van Assche
@ 2019-04-16 2:18 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2019-04-16 2:18 UTC (permalink / raw)
To: Stanley Chu
Cc: linux-scsi, martin.petersen, marc.w.gonzalez, andy.teng,
chun-hung.wu, kuohong.wang, evgreen, avri.altman, linux-mediatek,
peter.wang, alim.akhtar, matthias.bgg, pedrom.sousa,
linux-arm-kernel, beanhuo
Stanley,
> If UFS device responds an unknown request response code, we can not
> know what it was via logs because the code is replaced by "DID_ERROR
> << 16" before log printing.
>
> Fix this to provide precise request response code information for
> easier issue breakdown.
Applied to 5.2/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-16 2:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-15 12:23 [PATCH 1/1] scsi: ufs: Print real incorrect request response code Stanley Chu
2019-04-15 13:51 ` Bart Van Assche
2019-04-15 13:58 ` Winkler, Tomas
2019-04-16 2:18 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).