[PATCH v1 1/1] scsi: ufs: Print uic error history in time order

[PATCH v1 1/1] scsi: ufs: Print uic error history in time order

[Stanley Chu]

Now uic errors are printed out of time order.

Simply make it more readable by printing logs
in time order, and printing "No record" if history
is empty.

Signed-off-by: Stanley Chu <stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 drivers/scsi/ufs/ufshcd.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 9ba7671b84f8..f90badcb8318 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -393,15 +393,20 @@ static void ufshcd_print_uic_err_hist(struct ufs_hba *hba,
 		struct ufs_uic_err_reg_hist *err_hist, char *err_name)
 {
 	int i;
+	bool found = false;
 
 	for (i = 0; i < UIC_ERR_REG_HIST_LENGTH; i++) {
-		int p = (i + err_hist->pos - 1) % UIC_ERR_REG_HIST_LENGTH;
+		int p = (i + err_hist->pos) % UIC_ERR_REG_HIST_LENGTH;
 
 		if (err_hist->reg[p] == 0)
 			continue;
 		dev_err(hba->dev, "%s[%d] = 0x%x at %lld us\n", err_name, i,
 			err_hist->reg[p], ktime_to_us(err_hist->tstamp[p]));
+		found = true;
 	}
+
+	if (!found)
+		dev_err(hba->dev, "No record of %s uic errors\n", err_name);
 }
 
 static void ufshcd_print_host_regs(struct ufs_hba *hba)
-- 
2.18.0

RE: [PATCH v1 1/1] scsi: ufs: Print uic error history in time order

[Avri Altman]

> 
> Now uic errors are printed out of time order.
> 
> Simply make it more readable by printing logs
> in time order, and printing "No record" if history
> is empty.
> 
> Signed-off-by: Stanley Chu <stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Reviewed-by: Avri Altman <avri.altman-Sjgp3cTcYWE@public.gmane.org>

Re: [PATCH v1 1/1] scsi: ufs: Print uic error history in time order

[Martin K. Petersen]

Stanley,

> Now uic errors are printed out of time order.
>
> Simply make it more readable by printing logs in time order, and
> printing "No record" if history is empty.

Applied to 5.1/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

RE: [PATCH v1 1/1] scsi: ufs: Print uic error history in time order

[Bean Huo (beanhuo)]

Hi, Stanley
I tested it on my own platform. This is very useful and thanks.

>
>Now uic errors are printed out of time order.
>
>Simply make it more readable by printing logs in time order, and printing "No
>record" if history is empty.
>
>Signed-off-by: Stanley Chu <stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>---

Reviewed-by: Bean Huo <beanhuo-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org>
Tested-by: Bean Huo <beanhuo-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org>

RE: [PATCH v1 1/1] scsi: ufs: Print uic error history in time order

[Stanley Chu]

Hi Martin, 

Would you have any comment ?

Hi Bean and Avri,

Thanks so much for reviewing and testing.

On Wed, 2019-01-30 at 10:19 +0000, Bean Huo (beanhuo) wrote:
> Hi, Stanley
> I tested it on my own platform. This is very useful and thanks.
> 
> >
> >Now uic errors are printed out of time order.
> >
> >Simply make it more readable by printing logs in time order, and printing "No
> >record" if history is empty.
> >
> >Signed-off-by: Stanley Chu <stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> >---
> 
> Reviewed-by: Bean Huo <beanhuo-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org>
> Tested-by: Bean Huo <beanhuo-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org>

Thanks.

Stanley