From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: [RFC PATCH 02/16] hwmon: (ab8500) Call kernel_power_off instead of pm_power_off Date: Tue, 30 Sep 2014 11:00:42 -0700 Message-ID: <1412100056-15517-3-git-send-email-linux@roeck-us.net> References: <1412100056-15517-1-git-send-email-linux@roeck-us.net> Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=9PcH9vkqtbwsQEhiONThBwmzk2VQhEfeE7yLBkZxmg8=; b=SF6B8zhBABnJvHJcJpUhdlVKHl4srwi2kmAkFGImYdDKRg7wRv9uPAo8ouWn4WvJGc DfcKipMxk2k7unsqfOQ4D+YcPKOoQnkzscGCYFA6CffrqNlA9oF4n2Qg3B5iwLQ8/Kky TugkkGbVBhcSdRuaVY/oU5LjCwWnCesRw9EUANsHE9wNPAzP1SEpZIXS5QfumaFSYpLN UlJbdgjlZAFtlATlSNlNoixWS7w2y9aA8cvdaub7cONnDj+4mp1+3EIvBDUgbpbTt/VX nhlSV9jtGdgXBWVQ1F6hXoizor4KjQSOISt/2vWhFyDQ9h5oNelLtufDv56ROWV5M2Lc ksHQ== In-Reply-To: <1412100056-15517-1-git-send-email-linux@roeck-us.net> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: List-subscribe: List-owner: List-post: List-archive: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-ia64@vger.kernel.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, xen-devel@lists.xenproject.org, Guenter Roeck , Jean Delvare Drivers should not call pm_power_off directly; it is not guaranteed to be non-NULL. Call kernel_power_off instead. Cc: Jean Delvare Signed-off-by: Guenter Roeck --- I already submitted this patch separately as non-RFC. It is included in this series for completeness. drivers/hwmon/ab8500.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/ab8500.c b/drivers/hwmon/ab8500.c index d844dc8..8b6a4f4 100644 --- a/drivers/hwmon/ab8500.c +++ b/drivers/hwmon/ab8500.c @@ -6,7 +6,7 @@ * * When the AB8500 thermal warning temperature is reached (threshold cannot * be changed by SW), an interrupt is set, and if no further action is taken - * within a certain time frame, pm_power off will be called. + * within a certain time frame, kernel_power_off will be called. * * When AB8500 thermal shutdown temperature is reached a hardware shutdown of * the AB8500 will occur. @@ -21,6 +21,7 @@ #include #include #include +#include #include #include #include "abx500.h" @@ -106,7 +107,7 @@ static void ab8500_thermal_power_off(struct work_struct *work) dev_warn(&abx500_data->pdev->dev, "Power off due to critical temp\n"); - pm_power_off(); + kernel_power_off(); } static ssize_t ab8500_show_name(struct device *dev, -- 1.9.1