From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Dowad Subject: [PATCHv2 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg' Date: Mon, 16 Mar 2015 15:13:50 +0200 Message-ID: <1426511630-19370-1-git-send-email-alexinbeijing@gmail.com> References: <5506C0E0.80901@imgtec.com> Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UJaw6bGPJokUXqvCVPc7WApz2ciPp+N12PrfOEWpanY=; b=YDzjW99VHwbfN8og77lfVGbdOHBDQHOdBD9n2y5dWadFEmfDs3V+ptD4f2bdVNYSLc VTtFO5/hS0rLfT+lRYv2Besg2xb/9pf3JOnZ7caJ5d1h2ncwuWjAQki783rUxtlD97GQ bEmI5zbwJVEdSKSj09ZWKWNYbn1zI28EmJ7coiyeIQR8UjEGh6nb2r2oy4eSrS0TIZxI y7Fn4lZhBptp4+ErxNuXRm6pkM1+IEZJio1yRORotOQMX7W14SGoIgq0LHXYAb8A77sC tcmA7xe3h0oWk3gCd1pwyR9SjJ1nfAQOVb0aDuGxNLHMA8S4Ede+RwdQFCIoQQfPzwrK 5D4Q== In-Reply-To: <5506C0E0.80901@imgtec.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: james.hogan@imgtec.com Cc: linux-kernel@vger.kernel.org, linux-metag@vger.kernel.org The 'arg' argument to copy_thread() is only ever used when forking a new kernel thread. Hence, rename it to 'kthread_arg' for clarity. Signed-off-by: Alex Dowad --- James Hogan, Thanks for reviewing this patch. The comment has been updated as you suggested. You said: "I'll assume you plan to get all these patches merged together rather than via individual arch trees..." The truth is that I am as green as green can be and have no idea how I plan to get these patches merged. I was just reading the Linux source and saw what looked like an opportunity to make the code a tiny bit easier to read. If you have any suggestions on how to proceed, please let me know. Kind regards, Alex Dowad arch/metag/kernel/process.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c index 483dff9..dcb4609 100644 --- a/arch/metag/kernel/process.c +++ b/arch/metag/kernel/process.c @@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs) show_trace(NULL, (unsigned long *)regs->ctx.AX[0].U0, regs); } +/* + * Copy architecture-specific thread state + */ int copy_thread(unsigned long clone_flags, unsigned long usp, - unsigned long arg, struct task_struct *tsk) + unsigned long kthread_arg, struct task_struct *tsk) { struct pt_regs *childregs = task_pt_regs(tsk); void *kernel_context = ((void *) childregs + @@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsigned long usp, childregs->ctx.AX[0].U0 = (unsigned long) kernel_context; - /* Set D1Ar1=arg and D1RtP=usp (fn) */ + /* Set D1Ar1=kthread_arg and D1RtP=usp (fn) */ childregs->ctx.DX[4].U1 = usp; - childregs->ctx.DX[3].U1 = arg; + childregs->ctx.DX[3].U1 = kthread_arg; tsk->thread.int_depth = 2; return 0; } + /* * Get a pointer to where the new child's register block should have * been pushed. -- 2.0.0.GIT