From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 3/4] exit_thread: accept a task parameter to be exited Date: Thu, 24 Mar 2016 15:36:58 +0000 Message-ID: <20160324153658.GU19428@n2100.arm.linux.org.uk> References: <1458824294-29733-1-git-send-email-jslaby@suse.cz> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=NAKSPG7PDxWNTRzT8eeeyXgk7QQAxNM+pQq+uuDQ+3E=; b=MmlhFawqWP4SpdnsZisGViB0tVTSy+NiD2cPFB597lCmQkG/9+BfQwPbWwq7mIw/U3kVeNeGTPxCR0jDcTZe8UjRYfrNMhtrLU7GoKZB9x6dx+yyX8Iz3Q+8g/yDKS8y0Zh5EUWtPqED7W0PdZMMEMYVjc8UcrGC923dT/FSBzw=; Content-Disposition: inline In-Reply-To: <1458824294-29733-1-git-send-email-jslaby@suse.cz> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: List-subscribe: List-owner: List-post: List-archive: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jiri Slaby Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Catalin Marinas , Will Deacon , Haavard Skinnemoen , Hans-Christian Egtvedt , Steven Miao , Mark Salter , Aurelien Jacquiot , Mikael Starvik , Jesper Nilsson , Yoshinori Sato , Richard Kuo , Tony Luck , Fenghua Yu , Geert Uytterhoeven On Thu, Mar 24, 2016 at 01:58:13PM +0100, Jiri Slaby wrote: > We need to call exit_thread from copy_process in a fail path. So make > it accept task_struct as a parameter. Hmm, so what this means is that exit_thread() can now be called for threads which are not running on the CPU. So, I think the comment in arch/arm/vfp/vfpmodule.c needs to be updated: * THREAD_NOTIFY_EXIT * - the thread (v) will be running on the local CPU, so * v === current_thread_info() along with this change, since that becomes false. The code, however, looks like it'll cope just fine with that being false, as will the other users of THREAD_NOTIFY_EXIT in ARM. Thanks. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.