From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH] metag: Fix atomic_*_return inline asm constraints Date: Tue, 3 May 2016 09:54:57 +0100 Message-ID: <20160503085457.GC15188@jhogan-linux.le.imgtec.org> References: <1462264859-26544-1-git-send-email-james.hogan@imgtec.com> <20160503085246.GK3430@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NU0Ex4SbNnrxsi6C" Return-path: Content-Disposition: inline In-Reply-To: <20160503085246.GK3430-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org> Sender: linux-metag-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: To: Peter Zijlstra Cc: linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org --NU0Ex4SbNnrxsi6C Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 03, 2016 at 10:52:46AM +0200, Peter Zijlstra wrote: > On Tue, May 03, 2016 at 09:40:59AM +0100, James Hogan wrote: > > The argument i of atomic_*_return() operations is given to inline asm > > with the "bd" constraint, which means "An Op2 register where Op1 is a > > data unit register and the instruction supports O2R", however Op1 is > > constrained by "da" which allows an address unit register to be used. > >=20 > > Fix the constraint to use "br", meaning "An Op2 register and the > > instruction supports O2R", i.e. not requiring Op1 to be a data unit > > register. > >=20 > > Fixes: d6dfe2509da9 ("locking,arch,metag: Fold atomic_ops") > > Signed-off-by: James Hogan > > Cc: Peter Zijlstra > > Cc: linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >=20 > Thanks James, I'd give an ack, but I really don't know about these funny > constraints you have, so I'm not sure it'd actually mean something. No problem, meta is quite a quirky and non-orthogonal architecture. I've applied anyway. Thanks James --NU0Ex4SbNnrxsi6C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXKGdhAAoJEGwLaZPeOHZ6GXwQAJtLHfjkh39fYdegzevJm/hf dWDpC8B9CO4nWfmp9Xt4uMSF4Wp6ofBQnFaMC9saqs7zBL4uqz53J0FoyK4EvC+Y DcJZkpnCQGDsNNTVsKp31kZ14cds6uMGC7z8gBzVgPau6Oxhs0xNGUR1iCDiSah6 ERzjjbalv+9/IU0y+aXKXXQo/qSuRp/sXsPBgLZPg3NNkOG5ilvE82ia6cm6baK1 rrGRWzPmtm61oi2Uikr7ZMdpMiR1+7tb1E9ZGT3LvENEzsV6kQrMLSsdHltXIb34 FHZ03/Zz45WTiaI6HyZgRm4QL/TcZAAJvKfZ85GSCuLlMQdF2EF3YoCD7iT68wRH l1BG6BPBiVsozOclin4DYyhCYj70ziu9YYfc3vM4Jhn5ZJmiot+10lOqQQtOwlve M9Ysce9zwnEtU6PqkQTtCDAGLsJmpHSIUEfzMRo8/9jOFn3URr53E6z1frhhdpek gH44OXFgVRC6cMcmlQbOjm7Sa/jd3Vj0D0aSj9FKaJbFrFWdGAnLxSPwunyu+s24 DvY1ysY+HXO6Ufk4y4gXnGu0Q1oSMxTPEUhDM8Qgb2jzPqzp4ppUGMtKojTATN78 8/x/saSy8zKi4tsdPn/u1zQ3d2pO+KlK0nVGl/hg/kgP8zAat55lQSVV+s390S0N PfVg3+2qdMexZ/NR8NK5 =jGZx -----END PGP SIGNATURE----- --NU0Ex4SbNnrxsi6C--