From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mel Gorman Subject: Re: [PATCH 03/34] mm, vmscan: move LRU lists to node Date: Fri, 5 Aug 2016 12:55:26 +0100 Message-ID: <20160805115526.GS2799@techsingularity.net> References: <1467970510-21195-1-git-send-email-mgorman@techsingularity.net> <1467970510-21195-4-git-send-email-mgorman@techsingularity.net> <20160805084115.GO2799@techsingularity.net> <20160805105256.GH19514@jhogan-linux.le.imgtec.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20160805105256.GH19514-4bYivNCBEGTR3KXKvIWQxtm+Uo4AYnCiHZ5vskTnxNA@public.gmane.org> Sender: linux-metag-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: James Hogan Cc: Andrew Morton , Linux-MM , Rik van Riel , Vlastimil Babka , Johannes Weiner , Minchan Kim , Joonsoo Kim , LKML , metag On Fri, Aug 05, 2016 at 11:52:57AM +0100, James Hogan wrote: > > What's surprising is that it worked for the zone stats as it appears > > that calling zone_reclaimable() from that context should also have > > broken. Did anything change recently that would have avoided the > > zone->pageset dereference in zone_reclaimable() before? > > It appears that zone_pcp_init() was already setting zone->pageset to > &boot_pageset, via paging_init(): > /me slaps self Of course. > > The easiest option would be to not call show_mem from arch code until > > after the pagesets are setup. > > Since no other arches seem to do show_mem earily during boot like metag, > and doing so doesn't really add much value, I'm happy to remove it > anyway. > Thanks. Can I assume you'll merge such a patch or should I roll one? > However could your change break other things and need fixing anyway? > Not that I'm aware of. There would have to be a node-based stat that has meaning that early in boot to have an effect. If one happened to added then it would need fixing but until then the complexity is unnecessary. -- Mel Gorman SUSE Labs