From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: [PATCH 03/11] au1100fb: remove a bogus dma_free_nonconsistent call Date: Fri, 16 Jun 2017 09:17:08 +0200 Message-ID: <20170616071716.17321-4-hch@lst.de> References: <20170616071716.17321-1-hch@lst.de> Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mzyfL1j+oHE2j8TLAgsEiH+CF+GpS7rWVB2aAzuYyPc=; b=n4jwvNv2gED2h5WpH+TdKhLoJ Hc2hws+cTIW0lA5Xmsa5KRdak8LTafmQsZAo66E8gmSrljaKluLf9Plpfi4p/aIUibu5U57lp3KTU tLT+MiAm5eVnTYS5CCstMxLgGGH8Ji6fmI/WlXkReN2urpgioA9E0fwTUtiZ3MVOu1DFfWE3yrFfm zIG6uq5ctBEu2+78ylAEN38IOj1wnW59h+IIVk8GPcArFVC71WYj4LH5qNG/nB/pYW0VjpDsRQmxB sve8anXUDprcMGnaRd/8mCBcAC/kwafLNC3xI++nkleqi8oSJSSeBfTEK1cECtlxo5DwvrbGpLK9S In-Reply-To: <20170616071716.17321-1-hch@lst.de> Sender: netdev-owner@vger.kernel.org List-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, netdev@vger.kernel.org, linux-metag@vger.kernel.org, nios2-dev@lists.rocketboards.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org au1100fb is using managed dma allocations, so it doesn't need to explicitly free the dma memory in the error path (and if it did it would have to use the managed version). Signed-off-by: Christoph Hellwig --- drivers/video/fbdev/au1100fb.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c index 35df2c1a8a63..8de42f617d16 100644 --- a/drivers/video/fbdev/au1100fb.c +++ b/drivers/video/fbdev/au1100fb.c @@ -532,10 +532,6 @@ static int au1100fb_drv_probe(struct platform_device *dev) clk_disable_unprepare(fbdev->lcdclk); clk_put(fbdev->lcdclk); } - if (fbdev->fb_mem) { - dma_free_noncoherent(&dev->dev, fbdev->fb_len, fbdev->fb_mem, - fbdev->fb_phys); - } if (fbdev->info.cmap.len != 0) { fb_dealloc_cmap(&fbdev->info.cmap); } -- 2.11.0