From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: metag build error in -next due to 'fs, elf: drop MAP_FIXED usage from elf_map' Date: Sun, 7 Jan 2018 20:12:16 -0800 Message-ID: <20180108041216.GA9132@roeck-us.net> References: <20180107010733.GA317@roeck-us.net> <20180107085031.GA24862@dhcp22.suse.cz> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DhSuueX3v4MZwT9fd84bKWPNvZilCE+UzIfxBcwr7tk=; b=EQQNReMVsVBIsfJ7VbaUzewR6c0syoAiRBAALnaWO7ywI4lSvMK8bDumJXflrgKYyr 8y6Xfse/+/04b/zPV8tOc9rDdS6i67gODOnkdqxjBqvjXdJFjlHnK1fzFD7T4XK2R3+z 2QsIvNMDcYy7MYD63azMpU77QkmqOqQXMqZWYj7+tdafvLkjC9NwZXSGBlq71A//3xce nnZLrwQPqz9cDxM389NUnzzboM5JCgRiYhBlYrCv5x/gscDe4offPiwDUA45v0FMtNpn Vj0whC/jQkqHq+1TJYg5GNNUd4Y6CraOJzvbenzXOba4I/de+cowthELsKwpQAKNTqAc bikQ== Content-Disposition: inline In-Reply-To: <20180107085031.GA24862@dhcp22.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: Andrew Morton , James Hogan , linux-metag@vger.kernel.org, linux-kernel@vger.kernel.org On Sun, Jan 07, 2018 at 09:50:31AM +0100, Michal Hocko wrote: > On Sat 06-01-18 17:07:33, Guenter Roeck wrote: > > The following build error is seen when building metag:meta2_defconfig > > or metag:tz1090_defconfig. > > > > arch/metag/kernel/process.c: In function '__metag_elf_map': > > arch/metag/kernel/process.c:421: error: 'tsk' undeclared > > Sorry about that and thanks for your report. The following should fix > the issue. Andrew, could you fold it to the original patch please? > --- > From 64da2e0c134ecf3936a4c36b949bcf2cdc98977e Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Sun, 7 Jan 2018 09:47:41 +0100 > Subject: [PATCH] fs-elf-drop-map_fixed-usage-from-elf_map-fix-fix > > The following build error is seen when building metag:meta2_defconfig > or metag:tz1090_defconfig. > > arch/metag/kernel/process.c: In function '__metag_elf_map': > arch/metag/kernel/process.c:421: error: 'tsk' undeclared > > Reported-by: Guenter Roeck > Signed-off-by: Michal Hocko Compiled and booted with qemu. Tested-by: Guenter Roeck Guenter > --- > arch/metag/kernel/process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c > index 9e007195038d..0cca2c95a091 100644 > --- a/arch/metag/kernel/process.c > +++ b/arch/metag/kernel/process.c > @@ -419,7 +419,7 @@ unsigned long __metag_elf_map(struct file *filep, unsigned long addr, > > if ((type & MAP_FIXED_NOREPLACE) && BAD_ADDR(map_addr)) > pr_info("%d (%s): Uhuuh, elf segment at %p requested but the memory is mapped already\n", > - task_pid_nr(current), tsk->comm, (void *)addr); > + task_pid_nr(current), current->comm, (void *)addr); > > if (!BAD_ADDR(map_addr) && tcm_tag != TCM_INVALID_TAG) { > struct tcm_allocation *tcm; > -- > 2.15.1 > > -- > Michal Hocko > SUSE Labs