From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH] arch: metag: lib: add "umoddi3.S" file for __umoddi3() Date: Fri, 20 Dec 2013 09:30:44 +0000 Message-ID: <52B40E44.9040603@imgtec.com> References: <52B2E0FA.7090805@gmail.com> <52B2E3DB.7010008@imgtec.com> <52B2F6B7.1050802@gmail.com> <52B2F8DC.8060006@imgtec.com> <52B3A0EA.9010801@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52B3A0EA.9010801@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Chen Gang Cc: rostedt@goodmis.org, "linux-kernel@vger.kernel.org" , linux-metag@vger.kernel.org On 20/12/13 01:44, Chen Gang wrote: > On 12/19/2013 09:47 PM, James Hogan wrote: >> No, I believe there shouldn't be any use of the C 64bit division/modulo >> operations in generic kernel code in the first place, so like I said >> before the code in question should be fixed to use the proper functions >> in . >> > > OK, thanks, your idea is one of fix ways. > > Hmm... for me, it is still not a bad idea to add "__umoddi3" to metag. NAK Please read this: http://yarchive.net/comp/linux/64bit_divide.html Cheers James