From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>,
andreas.dilger@intel.com, bergwolf@gmail.com,
jinshan.xiong@intel.com, oleg.drokin@intel.com,
jacques-charles.lafoucriere@cea.fr
Cc: devel@driverdev.osuosl.org, James Hogan <james.hogan@imgtec.com>,
linux-metag@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union
Date: Sat, 18 Jan 2014 17:50:34 +0800 [thread overview]
Message-ID: <52DA4E6A.1000308@gmail.com> (raw)
Unfortunately, not all compilers assumes the structures within a pack
region also need be packed (e.g. metag), so need add a pack explicitly
to satisfy all compilers.
The related error (under metag with allmodconfig):
CC [M] drivers/staging/lustre/lustre/lov/lov_pack.o
drivers/staging/lustre/lustre/lov/lov_pack.c: In function 'lov_getstripe':
drivers/staging/lustre/lustre/lov/lov_pack.c:630: error: duplicate case value
drivers/staging/lustre/lustre/lov/lov_pack.c:630: error: previously used here
And originally, all related code used "__attribute__((packed))", so
still use it instead of '__packed'.
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/staging/lustre/lustre/include/lustre/lustre_user.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
index 6b6c0240..0828b31 100644
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
@@ -345,7 +345,7 @@ struct lov_user_md_v3 { /* LOV EA user data (host-endian) */
* lmm_objects, use when writing */
__u16 lmm_layout_gen; /* layout generation number
* used when reading */
- };
+ } __attribute__((packed));
char lmm_pool_name[LOV_MAXPOOLNAME]; /* pool name */
struct lov_user_ost_data_v1 lmm_objects[0]; /* per-stripe data */
} __attribute__((packed));
--
1.7.11.7
next reply other threads:[~2014-01-18 9:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 9:50 Chen Gang [this message]
2014-01-18 10:05 ` [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union Dan Carpenter
2014-01-18 10:26 ` Chen Gang
2014-01-18 14:24 ` Dan Carpenter
2014-01-19 10:07 ` Chen Gang
[not found] ` <52DBA3D4.3090308-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-01-20 11:56 ` James Hogan
2014-01-20 12:30 ` Dan Carpenter
2014-01-20 12:37 ` James Hogan
2014-01-20 12:56 ` Dan Carpenter
2014-01-20 13:01 ` Dan Carpenter
2014-01-20 13:38 ` James Hogan
2014-01-20 21:13 ` Dan Carpenter
2014-01-21 10:36 ` James Hogan
2014-01-25 11:55 ` Chen Gang
2014-02-01 13:57 ` Chen Gang
2014-02-03 8:58 ` Dan Carpenter
2014-02-03 10:03 ` Chen Gang
[not found] ` <52EF6965.6040406-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-03 11:35 ` Chen Gang
2014-02-03 10:05 ` David Laight
2014-02-03 10:22 ` James Hogan
2014-02-03 10:30 ` Chen Gang
[not found] ` <52EF6DCC.6040807-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2014-02-03 10:35 ` David Laight
2014-02-03 11:02 ` James Hogan
2014-02-03 11:54 ` David Laight
[not found] ` <063D6719AE5E284EB5DD2968C1650D6D0F6B772B-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2014-02-03 10:25 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DA4E6A.1000308@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jacques-charles.lafoucriere@cea.fr \
--cc=james.hogan@imgtec.com \
--cc=jinshan.xiong@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).