From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [Xen-devel] [RFC PATCH 14/16] x86/xen: support poweroff through poweroff handler call chain Date: Thu, 02 Oct 2014 06:27:08 -0700 Message-ID: <542D52AC.3040009@roeck-us.net> References: <1412100056-15517-1-git-send-email-linux@roeck-us.net> <1412100056-15517-15-git-send-email-linux@roeck-us.net> <542D1EC4.10100@citrix.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=WoAA1w37VG1xh32TRD3BqYmoHXkZpHmAqNmf2NpTa7k=; b=VOLBvov6M20nyOq3o3f8HLUrVNcURQNoFKAx7BYoQtQ6lE8NOfc1I4r7KbXijjW9dAxjZL++blCh3Yz3DU/rxwEFIaKkUiE3ma0JD0NcmWrxpoTSp3F6wzxuSbcPlZd5wmudHTXUo1GcsJXOGw7Ts2qQb8HV6b5w4NVFK2B50co=; In-Reply-To: <542D1EC4.10100-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org> Sender: linux-metag-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: David Vrabel , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-c6x-dev-jPsnJVOj+W6hPH1hqNUYSQ@public.gmane.org, linux-parisc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, Boris Ostrovsky , linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org On 10/02/2014 02:45 AM, David Vrabel wrote: > On 30/09/14 19:00, Guenter Roeck wrote: >> The kernel core now supports a poweroff handler call chain >> to remove power from the system. Call it if pm_power_off >> is set to NULL. >> >> Cc: Konrad Rzeszutek Wilk >> Cc: Boris Ostrovsky >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: H. Peter Anvin >> Signed-off-by: Guenter Roeck >> --- >> arch/x86/xen/enlighten.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c >> index c0cb11f..645d00f 100644 >> --- a/arch/x86/xen/enlighten.c >> +++ b/arch/x86/xen/enlighten.c >> @@ -1322,6 +1322,8 @@ static void xen_machine_power_off(void) >> { >> if (pm_power_off) >> pm_power_off(); >> + else >> + do_kernel_poweroff(); > > Why isn't this if (pm_power_off) check in do_kernel_poweroff()? > > That way when you finally remove pm_power_off you need only update one > place. A quick skim of the other archs suggest this would work for them > too. > Good idea. I'll do that for the next version of the patch set. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-metag" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html