Re: [PATCHv2 16/32] metag: copy_thread(): rename 'arg' argument to 'kthread_arg'

Alex Dowad
2015-03-16T14:38:09Z

On 16/03/15 16:31, James Hogan wrote:
> Hi Alex,
>
> On 16/03/15 13:13, Alex Dowad wrote:
>> The 'arg' argument to copy_thread() is only ever used when forking a new
>> kernel thread. Hence, rename it to 'kthread_arg' for clarity.
>>
>> Signed-off-by: Alex Dowad <alexinbeijing@gmail.com>
>> ---
>>
>> James Hogan,
>>
>> Thanks for reviewing this patch. The comment has been updated as you suggested.
>>
>> You said: "I'll assume you plan to get all these patches merged together rather than
>> via individual arch trees..." The truth is that I am as green as green can be and have
>> no idea how I plan to get these patches merged. I was just reading the Linux source and
>> saw what looked like an opportunity to make the code a tiny bit easier to read. If you
>> have any suggestions on how to proceed, please let me know.
> I guess there are 3 main paths:
> 1) Ask individual arch maintainers to apply the patches if possible,
> since it doesn't have dependencies on other patches you're submitting.
> 2) Gather acks from maintainers for the remaining patches and ask Andrew
> Morton or another relevant maintainer to apply them (Andrew often picks
> up misc patches like this I believe).
> 3) Or gather acks for remaining patches and send a pull request to Linus
> yourself during the next merge window.
>
>
> Btw, the whitespace seems to be corrupted here, so the patch won't apply:
Grrr. Sending again.

Thanks for the pointers on merge workflow. I doubt that I will get the
attention of each and every arch maintainer, but let's see what will
happen. Thanks again.

>
>> - /* Set D1Ar1=arg and D1RtP=usp (fn) */
> ^^^ currently this is indented with tabs not spaces
>
>> + /* Set D1Ar1=kthread_arg and D1RtP=usp (fn) */
> ^^^ and this has a space before a tab
>
> Cheers
> James