From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Dowad <alexinbeijing@gmail.com>
Subject: Re: [PATCHv2 16/32] metag: copy_thread(): rename 'arg' argument to
 'kthread_arg'
Date: Mon, 16 Mar 2015 16:38:09 +0200
Message-ID: <5506EAD1.9000607@gmail.com>
References: <5506C0E0.80901@imgtec.com> <1426511630-19370-1-git-send-email-alexinbeijing@gmail.com> <5506E95D.70204@imgtec.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        bh=EQDXuZSqDC3Z0MMwrKvJKn6cXq98Gsfgr4ShRiEY9dk=;
        b=kWZ6CfcEviy2B7QkOVgK8PB1DkJbkC7TfCzKSilPU7+b4oz61MnB/kniN3aM+96lBs
         B9s6ii8jExkI+8i4MdJzc07+9gR+dQ9Bp2zPlOweklST6aoNjFdptb8fOW0vNrNQOj9O
         MXIozYXCLGFtmC3A5Rg+v1fXmyLgibOVcz88O6Pev3PJx5MOPK/X/XYP/iMVgi0WmFpb
         qOXOSBSSEvgIUb5daixrywDRPFJsdUN3O+Q3YQnvTEzUT804/HTpo9Ug+nbww1Bp0aII
         rZ29QxnjGMO6HV4grYZ+NvFnSUEEYm/XUfRrlrUc4ibKrxlkP/oXPtWFXjcsQcDhijfY
         0EJA==
In-Reply-To: <5506E95D.70204@imgtec.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-metag.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-kernel@vger.kernel.org, linux-metag@vger.kernel.org


On 16/03/15 16:31, James Hogan wrote:
> Hi Alex,
>
> On 16/03/15 13:13, Alex Dowad wrote:
>> The 'arg' argument to copy_thread() is only ever used when forking a new
>> kernel thread. Hence, rename it to 'kthread_arg' for clarity.
>>
>> Signed-off-by: Alex Dowad <alexinbeijing@gmail.com>
>> ---
>>
>> James Hogan,
>>
>> Thanks for reviewing this patch. The comment has been updated as you suggested.
>>
>> You said: "I'll assume you plan to get all these patches merged together rather than
>> via individual arch trees..." The truth is that I am as green as green can be and have
>> no idea how I plan to get these patches merged. I was just reading the Linux source and
>> saw what looked like an opportunity to make the code a tiny bit easier to read. If you
>> have any suggestions on how to proceed, please let me know.
> I guess there are 3 main paths:
> 1) Ask individual arch maintainers to apply the patches if possible,
> since it doesn't have dependencies on other patches you're submitting.
> 2) Gather acks from maintainers for the remaining patches and ask Andrew
> Morton or another relevant maintainer to apply them (Andrew often picks
> up misc patches like this I believe).
> 3) Or gather acks for remaining patches and send a pull request to Linus
> yourself during the next merge window.
>
>
> Btw, the whitespace seems to be corrupted here, so the patch won't apply:
Grrr. Sending again.

Thanks for the pointers on merge workflow. I doubt that I will get the 
attention of each and every arch maintainer, but let's see what will 
happen. Thanks again.

>
>> -   /* Set D1Ar1=arg and D1RtP=usp (fn) */
> ^^^ currently this is indented with tabs not spaces
>
>> + 	/* Set D1Ar1=kthread_arg and D1RtP=usp (fn) */
> ^^^ and this has a space before a tab
>
> Cheers
> James