From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: metag test failure in -next due to commit 'module: relocate module_init from init.h to module.h' Date: Fri, 05 Jun 2015 17:39:13 -0700 Message-ID: <55724131.9040900@roeck-us.net> References: <20150605204055.GA981@roeck-us.net> <20150605213900.GA30510@jhogan-linux.le.imgtec.org> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=0fsqmEvC9A3JdmkQlFD06o8Xq2iLcUK5zsBcSLrbHIk=; b=IooCE52AeeNbi9QXEjewlgErBz1sN6VG2GonXa00rA0Xbsw/4iSgplgkDOsPVehKqKDiWDJVytav3/O7V9RXpygBT77yOi1TvZVzD9bSm4a9WpEbMxitq6VorLCKxA4CWZo0LqBPfjsgzsCZo9JeWXBf9IIvx/xUcG5+W1oyuNk=; In-Reply-To: <20150605213900.GA30510-4bYivNCBEGTR3KXKvIWQxtm+Uo4AYnCiHZ5vskTnxNA@public.gmane.org> Sender: linux-metag-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="utf-8"; format="flowed" To: James Hogan , Paul Gortmaker Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg Kroah-Hartman , Jiri Slaby On 06/05/2015 02:39 PM, James Hogan wrote: [ ... ] > > From e12856c559d7dff2ad4f6497996610e12e7c7e2d Mon Sep 17 00:00:00 20= 01 > From: James Hogan > Date: Fri, 5 Jun 2015 22:17:18 +0100 > Subject: [PATCH] tty/metag_da: Avoid module_init/module_exit > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > The metag_da TTY driver can't get built as a module at the moment, bu= t > it still uses module_init() and module_exit(). Those macros are movin= g > to module.h which isn't included by metag_da.c, which will result in = the > following build warnings (remarkably no build errors) and an apparent > failure to boot as the TTY driver won't be loaded. > > drivers/tty/metag_da.c:660: warning: data definition has no type or s= torage class > drivers/tty/metag_da.c:660: warning: type defaults to =E2=80=98int=E2= =80=99 in declaration of =E2=80=98module_init=E2=80=99 > drivers/tty/metag_da.c:660: warning: parameter names (without types) = in function declaration > drivers/tty/metag_da.c:661: warning: data definition has no type or s= torage class > drivers/tty/metag_da.c:661: warning: type defaults to =E2=80=98int=E2= =80=99 in declaration of =E2=80=98module_exit=E2=80=99 > drivers/tty/metag_da.c:661: warning: parameter names (without types) = in function declaration > drivers/tty/metag_da.c:572: warning: =E2=80=98dashtty_init=E2=80=99 d= efined but not used > drivers/tty/metag_da.c:645: warning: =E2=80=98dashtty_exit=E2=80=99 d= efined but not used > drivers/tty/metag_da.c In function =E2=80=98dash_console_write=E2=80=99= : > drivers/tty/metag_da.c:670 : warning: passing argument 4 of =E2=80=98= chancall=E2=80=99 discards qualifiers from pointer target type > > Instead of just adding the module.h include, now would be a good time= to > remove the use of these macros, replacing the module_init with > device_initcall, and removing the exit function altogether since it > isn't needed. If module support is added later the code can always be > resurrected. > > Reported-by: Guenter Roeck > Signed-off-by: James Hogan > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: Paul Gortmaker > Cc: linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Yes, that does the trick. Tested-by: Guenter Roeck Thanks, Guenter