public inbox for linux-metag@vger.kernel.org
 help / color / mirror / Atom feed
* [tip:core/rcu] metag: Use common outgoing-CPU-notification code
@ 2015-03-27 11:33 tip-bot for Paul E. McKenney
  0 siblings, 0 replies; only message in thread
From: tip-bot for Paul E. McKenney @ 2015-03-27 11:33 UTC (permalink / raw)
  To: linux-tip-commits-u79uwXL29TY76Z2rM5mHXA
  Cc: james.hogan-1AXoQHu6uovQT0dZR+AlfA,
	linux-metag-u79uwXL29TY76Z2rM5mHXA, tglx-hfZtesqFncYOwBW4kG4KsQ,
	mingo-DgEjT+Ai2ygdnm+yROfE0A,
	paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8,
	hpa-YMNOUZJC4hwAvxtiuMwx3w

Commit-ID:  490ab882e2719f5e809a0cb5af7fda4620b66dca
Gitweb:     http://git.kernel.org/tip/490ab882e2719f5e809a0cb5af7fda4620b66dca
Author:     Paul E. McKenney <paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
AuthorDate: Thu, 26 Feb 2015 14:57:25 -0800
Committer:  Paul E. McKenney <paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
CommitDate: Wed, 11 Mar 2015 13:22:36 -0700

metag: Use common outgoing-CPU-notification code

This commit removes the open-coded CPU-offline notification with new
common code.  This change avoids calling scheduler code using RCU from
an offline CPU that RCU is ignoring.  This commit is compatible with
the existing code in not checking for timeout during a prior offline
for a given CPU.

Signed-off-by: Paul E. McKenney <paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Cc: <linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
---
 arch/metag/kernel/smp.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/metag/kernel/smp.c b/arch/metag/kernel/smp.c
index f006d22..ac3a199 100644
--- a/arch/metag/kernel/smp.c
+++ b/arch/metag/kernel/smp.c
@@ -261,7 +261,6 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
 }
 
 #ifdef CONFIG_HOTPLUG_CPU
-static DECLARE_COMPLETION(cpu_killed);
 
 /*
  * __cpu_disable runs on the processor to be shutdown.
@@ -299,7 +298,7 @@ int __cpu_disable(void)
  */
 void __cpu_die(unsigned int cpu)
 {
-	if (!wait_for_completion_timeout(&cpu_killed, msecs_to_jiffies(1)))
+	if (!cpu_wait_death(cpu, 1))
 		pr_err("CPU%u: unable to kill\n", cpu);
 }
 
@@ -314,7 +313,7 @@ void cpu_die(void)
 	local_irq_disable();
 	idle_task_exit();
 
-	complete(&cpu_killed);
+	(void)cpu_report_death();
 
 	asm ("XOR	TXENABLE, D0Re0,D0Re0\n");
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-metag" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-03-27 11:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-27 11:33 [tip:core/rcu] metag: Use common outgoing-CPU-notification code tip-bot for Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox