From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 28 Mar 2013 22:30:28 +0100 (CET) Received: from mail-ee0-f43.google.com ([74.125.83.43]:64683 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6827486Ab3C1Va1I1fZt (ORCPT ); Thu, 28 Mar 2013 22:30:27 +0100 Received: by mail-ee0-f43.google.com with SMTP id e50so1160883eek.2 for ; Thu, 28 Mar 2013 14:30:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-type:content-transfer-encoding :x-mailer:thread-index:content-language:x-gm-message-state; bh=CtvNZTi4cfTIrE8j8O3zi0KcPo7QNlR9tLPKgeN0lB4=; b=dn5I1mVc/P6QF4RYsbunj3s/o7HquJvJNz3q/C5AEGQ7oXhtsbjLns75LKVOnmDfc7 HBbJbuMKzCePsmsksWjgw+LU/9B9FVsHfByr367YRqpeOnG9qw3hkuDiAsM6MDUwA+do FuCTt1KidjSZ/m9YJNyWVWyCOcOFi2e5tEqBZD/tKDMWG+47L2fsU2NgBlXMVwFslSm7 BP4oJ2Y4zvI90ss+KiB8k3xvp4FHQai27IJZ29qlKlhzIikzPVg3QTszYT06Pu/SUoMy 5r7/wAdIqEBK9Bc47vAMBVzcvVVsDcZmZQfJEDKsy7SWgbAo8/+DtOKJcovKoznStyix OSYQ== X-Received: by 10.14.183.198 with SMTP id q46mr680386eem.1.1364506221178; Thu, 28 Mar 2013 14:30:21 -0700 (PDT) Received: from hotrod ([77.70.100.51]) by mx.google.com with ESMTPS id 3sm419560eej.6.2013.03.28.14.30.18 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 28 Mar 2013 14:30:20 -0700 (PDT) From: "Svetoslav Neykov" To: "'Michael Grzeschik'" , "'Alexander Shishkin'" Cc: "'Ralf Baechle'" , "'Greg Kroah-Hartman'" , "'Gabor Juhos'" , "'John Crispin'" , "'Alan Stern'" , "'Luis R. Rodriguez'" , , References: <1362176257-2328-1-git-send-email-svetoslav@neykov.name> <1362176257-2328-2-git-send-email-svetoslav@neykov.name> <878v57kh4v.fsf@ashishki-desk.ger.corp.intel.com> <20130328141253.GA5079@pengutronix.de> In-Reply-To: <20130328141253.GA5079@pengutronix.de> Subject: RE: [PATCH v2 1/2] usb: chipidea: big-endian support Date: Thu, 28 Mar 2013 23:30:15 +0200 Message-ID: <023101ce2bfb$712ea0f0$538be2d0$@neykov.name> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 thread-index: AQJ6crEKrmvOIJbIiJ7dXEbCRe8hgQIpA3+vAboxlnUBd4AGupc4Ojdg Content-Language: bg X-Gm-Message-State: ALoCoQnREJXGBVy0cSfxmKP/yiI2UFg7ku2FBwJeS9YJIYx00iuhtjqMkq+G0qnd0dfxQGr8tq+H X-archive-position: 35990 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: svetoslav@neykov.name Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: Hi Michael, On Thu, March 28, 2013 4:13 PM Michael Grzeschik wrote: >On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote: >> Svetoslav Neykov writes: >> >> > Convert between big-endian and little-endian format when accessing the usb controller structures which are little-endian by specification. >> > Fix cases where the little-endian memory layout is taken for granted. >> > The patch doesn't have any effect on the already supported >> > little-endian architectures. >> >> Applied to my branch of things that are aiming at v3.10. Next time >> please make sure that it applies cleanly. > >I am currently rebasing my fix/cleanup/feature patches against your >ci-for-greg and realised that this patch missed to fix debug.c with >cpu_le_32 action. Is someone volunteering to cook a patch? I will gladly make the changes, but after having a look at it I didn't spot any candidates. The DMA buffers are printed either as addresses in memory or as raw data which doesn't make sense to be cpu_le_32'ed. If Alexander hasn't already made the changes could you point me to the lines in question. Thanks, Svetoslav. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ee0-f43.google.com ([74.125.83.43]:64683 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6827486Ab3C1Va1I1fZt (ORCPT ); Thu, 28 Mar 2013 22:30:27 +0100 Received: by mail-ee0-f43.google.com with SMTP id e50so1160883eek.2 for ; Thu, 28 Mar 2013 14:30:21 -0700 (PDT) From: "Svetoslav Neykov" References: <1362176257-2328-1-git-send-email-svetoslav@neykov.name> <1362176257-2328-2-git-send-email-svetoslav@neykov.name> <878v57kh4v.fsf@ashishki-desk.ger.corp.intel.com> <20130328141253.GA5079@pengutronix.de> In-Reply-To: <20130328141253.GA5079@pengutronix.de> Subject: RE: [PATCH v2 1/2] usb: chipidea: big-endian support Date: Thu, 28 Mar 2013 23:30:15 +0200 Message-ID: <023101ce2bfb$712ea0f0$538be2d0$@neykov.name> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Language: bg Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: Return-Path: To: 'Michael Grzeschik' , 'Alexander Shishkin' Cc: 'Ralf Baechle' , 'Greg Kroah-Hartman' , 'Gabor Juhos' , 'John Crispin' , 'Alan Stern' , "'Luis R. Rodriguez'" , linux-mips@linux-mips.org, linux-usb@vger.kernel.org Message-ID: <20130328213015.0R2fmH2kO3xymkCb4-SuBtjt7ecroktrQYFlClWf3Ds@z> Hi Michael, On Thu, March 28, 2013 4:13 PM Michael Grzeschik wrote: >On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote: >> Svetoslav Neykov writes: >> >> > Convert between big-endian and little-endian format when accessing the usb controller structures which are little-endian by specification. >> > Fix cases where the little-endian memory layout is taken for granted. >> > The patch doesn't have any effect on the already supported >> > little-endian architectures. >> >> Applied to my branch of things that are aiming at v3.10. Next time >> please make sure that it applies cleanly. > >I am currently rebasing my fix/cleanup/feature patches against your >ci-for-greg and realised that this patch missed to fix debug.c with >cpu_le_32 action. Is someone volunteering to cook a patch? I will gladly make the changes, but after having a look at it I didn't spot any candidates. The DMA buffers are printed either as addresses in memory or as raw data which doesn't make sense to be cpu_le_32'ed. If Alexander hasn't already made the changes could you point me to the lines in question. Thanks, Svetoslav.