From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D9DC433EF for ; Mon, 25 Oct 2021 14:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BDCB60EBB for ; Mon, 25 Oct 2021 14:26:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233535AbhJYO2q (ORCPT ); Mon, 25 Oct 2021 10:28:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21285 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233545AbhJYO2p (ORCPT ); Mon, 25 Oct 2021 10:28:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635171983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0JDFR/w0BO+fJnaqyJz0KqLIzoSXAKAPvBzPCJS8rh0=; b=hbCJMtC+feXdD4DZpsFhxR0KHosx1zwzyF8Tv1JUfLQGhFPT6Sz9jaYEhXZ8ctLiBr5K/+ 1Af4KNf2fipA4V/TwlqSvOhuL0s5hBfhvsM7MGI8li9fR49uEYSSeK/5IpxDydkWDJz9qy I/Q+pHO5qIr6muF9tbKPliOWf9AUoz0= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-6Fc7JjJjPcm1rBG3KPPD9w-1; Mon, 25 Oct 2021 10:26:22 -0400 X-MC-Unique: 6Fc7JjJjPcm1rBG3KPPD9w-1 Received: by mail-ed1-f69.google.com with SMTP id g6-20020a056402424600b003dd2b85563bso7375318edb.7 for ; Mon, 25 Oct 2021 07:26:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0JDFR/w0BO+fJnaqyJz0KqLIzoSXAKAPvBzPCJS8rh0=; b=3E4r7h/TeeqbaTejaxnXtybTuzW3KdLbeLRsunasvnb4kv2TMbkKs8eL6WLStM+wAI VOROFX49MQOA1VG7nln2T5ODAJVI3cXBFRtVksDILDeQ/kPY2evaxTIzQKnwwiIfoyMc vSRGzT8FZjsAqT6QcIPsNkUBEMyJNgrAK6e6+3LAXRFYSn2Ttiw6fukaaJbUQACJ6pJg vHO05eLMeAQ2tw5HSmoui5/Dby/GOkMaG07oV/S/h8cwoZQE72Wnf48oGRZ46nCbM8wr F+tXFXVcLjN8addOhi9HPEuTeoAMH2N8LaF95d4sb3cvUfAi5ySOSUAgzljYOvdyGV7P 5LSg== X-Gm-Message-State: AOAM533sVkcorHburoZkwwY6yl3hi24NgETnq3Wm2wERuQfYs1iS7qcU pWVkkdlcSL45x9IPrK+gVNYbd5GuhvsPo89kk8nMc95j9JrT2QC96Lz+y9Vj3wRffziM7j0kIqL W/If5YrXteLgN7LA/B27KGQ== X-Received: by 2002:a50:d78c:: with SMTP id w12mr26913807edi.147.1635171980781; Mon, 25 Oct 2021 07:26:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKDlcJy9Ggfa6iOgv+1CVaZWvopovsowDbFDE9dApjZRuZhu/xUobrIcg2Oe5NEBC4id/OJQ== X-Received: by 2002:a50:d78c:: with SMTP id w12mr26913764edi.147.1635171980582; Mon, 25 Oct 2021 07:26:20 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id hs28sm1430847ejc.111.2021.10.25.07.26.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 07:26:19 -0700 (PDT) Message-ID: <0333be2a-76d8-657a-6c82-3bb5c9ff2e3b@redhat.com> Date: Mon, 25 Oct 2021 16:26:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 35/43] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode Content-Language: en-US To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-36-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-36-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 09/10/21 04:12, Sean Christopherson wrote: > + */ > + if (vcpu->mode == IN_GUEST_MODE) { > int cpu = READ_ONCE(vcpu->cpu); > > /* > @@ -687,8 +692,13 @@ int svm_deliver_avic_intr(struct kvm_vcpu *vcpu, int vec) > if (cpu != get_cpu()) > wrmsrl(SVM_AVIC_DOORBELL, kvm_cpu_get_apicid(cpu)); > put_cpu(); > - } else > + } else { > + /* > + * Wake the vCPU if it was blocking. KVM will then detect the > + * pending IRQ when checking if the vCPU has a wake event. > + */ > kvm_vcpu_wake_up(vcpu); > + } > Does this still need to check the "running" flag? That should be a strict superset of vcpu->mode == IN_GUEST_MODE. Paolo