From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D8EC433FE for ; Mon, 21 Feb 2022 01:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234180AbiBUB23 (ORCPT ); Sun, 20 Feb 2022 20:28:29 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233987AbiBUB22 (ORCPT ); Sun, 20 Feb 2022 20:28:28 -0500 Received: from 189.cn (ptr.189.cn [183.61.185.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D654222506; Sun, 20 Feb 2022 17:28:04 -0800 (PST) HMM_SOURCE_IP: 10.64.8.41:55796.1374937723 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-114.242.206.180 (unknown [10.64.8.41]) by 189.cn (HERMES) with SMTP id 9CEA6100114; Mon, 21 Feb 2022 09:27:51 +0800 (CST) Received: from ([172.27.8.53]) by gateway-151646-dep-b7fbf7d79-9vctg with ESMTP id 33968a4650c64d8492bd84a8ba4934bc for jiaxun.yang@flygoat.com; Mon, 21 Feb 2022 09:28:03 CST X-Transaction-ID: 33968a4650c64d8492bd84a8ba4934bc X-Real-From: 15330273260@189.cn X-Receive-IP: 172.27.8.53 X-MEDUSA-Status: 0 Sender: 15330273260@189.cn Message-ID: <034c425e-bcd8-0fe4-f10c-3ef297ffcc72@189.cn> Date: Mon, 21 Feb 2022 09:27:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v10 1/4] MIPS: Loongson64: dts: update the display controller device node Content-Language: en-US To: Jiaxun Yang , Maxime Ripard , Thomas Zimmermann , Roland Scheidegger , Zack Rusin , Christian Gmeiner , David Airlie , Daniel Vetter , Rob Herring , Thomas Bogendoerfer , Dan Carpenter , Krzysztof Kozlowski , Andrey Zhizhikin , Sam Ravnborg , "David S . Miller" , Lucas Stach , Maarten Lankhorst , Ilia Mirkin , Qing Zhang , suijingfeng Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20220220145554.117854-1-15330273260@189.cn> <20220220145554.117854-2-15330273260@189.cn> From: Sui Jingfeng <15330273260@189.cn> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 2022/2/21 02:18, Jiaxun Yang wrote: > > > 在 2022/2/20 14:55, Sui Jingfeng 写道: >> From: suijingfeng >> >> The display controller is a pci device, its PCI vendor id is 0x0014 >> its PCI device id is 0x7a06. >> >> 1) In order to let the driver to know which chip the DC is contained >>     in, the compatible string of the display controller is updated >>     according to the chip's name. >> >> 2) Add display controller device node for ls2k1000 SoC >> >> Reported-by: Krzysztof Kozlowski > ^ The usage of Reported-by flag seems wired here. > In most case we use it to credit people who find a bug that is already > in-tree. > Reviewing effort is already credited by Reviewed-by flag. > > If you intend to let maintainers track their suggestions easier, the > common > practice is to append suggester's name after each entry of changelog > between versions. > > Thanks. Ok, Now I know that. I will revise it next time, thank you. > >> Signed-off-by: suijingfeng >> Signed-off-by: Sui Jingfeng <15330273260@189.cn> >> --- >>   arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 8 ++++++++ >>   arch/mips/boot/dts/loongson/ls7a-pch.dtsi          | 7 ++----- >>   2 files changed, 10 insertions(+), 5 deletions(-) >> > [...] > - Jiaxun