AW: [PATCH] irqchip/mips-gic: allow forced affinity for current cpu during hotplug

[<markus.stockhausen@gmx.de>]

> Von: Thomas Gleixner <tglx@linutronix.de> 
>
> On Fri, May 23 2025 at 11:15, Markus Stockhausen wrote:
> > +
> > +	if ((cpu >= NR_CPUS) && !force)
> > +		/* In normal mode allow only online CPUs. */
> >  		return -EINVAL;
> >  
> > +	if (cpu >= NR_CPUS) {
> > +		/* In force mode allow current not yet online CPU for
hotplug handlers. */
> > +		cpu = cpumask_first(cpumask);
> > +		if (cpu != get_cpu())
> > +			return -EINVAL;
> > +	}
>
> This logic really makes my brain hurt. Why not doing the obvious:
>
>	if (cpu >= NR_CPUS) {
>         	/* Sensible comment */	
>         	if (!force)
>                 	return -EINVAL;
>                 ...
>         }

Then what about an even more relaxed and cleaner version like in other
drivers?

If (force)
  cpu = cpumask_first(cpumask);
else
  cpu = cpumask_first_and(cpumask, cpu_online_mask);

Markus