From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 13 Apr 2004 02:12:07 +0100 (BST) Received: from ispmxmta09-srv.alltel.net ([IPv6:::ffff:166.102.165.170]:43484 "EHLO ispmxmta09-srv.alltel.net") by linux-mips.org with ESMTP id ; Tue, 13 Apr 2004 02:12:06 +0100 Received: from lahoo.priv ([162.39.1.206]) by ispmxmta09-srv.alltel.net with ESMTP id <20040413011159.DXUD2984.ispmxmta09-srv.alltel.net@lahoo.priv>; Mon, 12 Apr 2004 20:11:59 -0500 Received: from prefect.priv ([10.1.1.141] helo=prefect) by lahoo.priv with smtp (Exim 3.36 #1 (Debian)) id 1BDCEy-0007HP-00; Mon, 12 Apr 2004 20:57:28 -0400 Message-ID: <04f501c420f4$5563f620$8d01010a@prefect> From: "Bradley D. LaRonde" To: "Daniel Jacobowitz" Cc: , "Eric Christopher" References: <20040412231309.GA702@linux-mips.org> <03f301c420e7$d8de2d70$8d01010a@prefect> <048e01c420f1$ad4ae3b0$8d01010a@prefect> <1081818125.19719.14.camel@dzur.sfbay.redhat.com> <04d501c420f3$6c836a30$8d01010a@prefect> <20040413010732.GA7560@nevyn.them.org> Subject: Re: [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi" intime.c Date: Mon, 12 Apr 2004 21:12:04 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1158 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 4763 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: brad@laronde.org Precedence: bulk X-list: linux-mips ----- Original Message ----- From: "Daniel Jacobowitz" To: "Bradley D. LaRonde" Cc: ; "Eric Christopher" Sent: Monday, April 12, 2004 9:07 PM Subject: Re: [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi" intime.c > On Mon, Apr 12, 2004 at 09:05:34PM -0400, Bradley D. LaRonde wrote: > > ----- Original Message ----- > > From: "Eric Christopher" > > To: "Bradley D. LaRonde" > > Cc: > > Sent: Monday, April 12, 2004 9:02 PM > > Subject: Re: [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi" > > intime.c > > > > > > > On Mon, 2004-04-12 at 17:53, Bradley D. LaRonde wrote: > > > > Uh oh, with this patch: > > > > > > > > ... > > > > time.c: In function `fixed_rate_gettimeoffset': > > > > time.c:242: error: can't find a register in class `HI_REG' while > > reloading > > > > `asm' > > > > ... > > > > > > > > > > > > > /* > > > > > * Due to possible jiffies inconsistencies, we need to check > > > > > @@ -339,7 +339,7 @@ > > > > > : "r" (timerhi), "m" (timerlo), > > > > > "r" (tmp), "r" (USECS_PER_JIFFY), > > > > > "r" (USECS_PER_JIFFY_FRAC) > > > > > - : "hi", "lo", "accum"); > > > > > + : "hi", "lo", "hi"); > > > > > cached_quotient = quotient; > > > > > > > > > Maybe this hunk where you use "hi" twice for the same asm statement? > > > > Yeah, that's messed up, but it fails here too: > > > > @@ -242,7 +242,7 @@ > > __asm__("multu %1,%2" > > : "=h" (res) > > : "r" (count), "r" (sll32_usecs_per_cycle) > > - : "lo", "accum"); > > + : "lo", "hi"); > > Because the asm is outputting something in HI - see the =h? Oh... yeah, I guess gcc knows that the output is clobbered. :-P So just remove the accum clobbers? Regards, Brad From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <04f501c420f4$5563f620$8d01010a@prefect> From: "Bradley D. LaRonde" References: <20040412231309.GA702@linux-mips.org> <03f301c420e7$d8de2d70$8d01010a@prefect> <048e01c420f1$ad4ae3b0$8d01010a@prefect> <1081818125.19719.14.camel@dzur.sfbay.redhat.com> <04d501c420f3$6c836a30$8d01010a@prefect> <20040413010732.GA7560@nevyn.them.org> Subject: Re: [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi" intime.c Date: Mon, 12 Apr 2004 21:12:04 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org To: Daniel Jacobowitz Cc: linux-mips@linux-mips.org, Eric Christopher Message-ID: <20040413011204.7phb5Mbbv8mH9CpDU8A9xuYtZko7y0W7a1zPAN6moAc@z> ----- Original Message ----- From: "Daniel Jacobowitz" To: "Bradley D. LaRonde" Cc: ; "Eric Christopher" Sent: Monday, April 12, 2004 9:07 PM Subject: Re: [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi" intime.c > On Mon, Apr 12, 2004 at 09:05:34PM -0400, Bradley D. LaRonde wrote: > > ----- Original Message ----- > > From: "Eric Christopher" > > To: "Bradley D. LaRonde" > > Cc: > > Sent: Monday, April 12, 2004 9:02 PM > > Subject: Re: [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi" > > intime.c > > > > > > > On Mon, 2004-04-12 at 17:53, Bradley D. LaRonde wrote: > > > > Uh oh, with this patch: > > > > > > > > ... > > > > time.c: In function `fixed_rate_gettimeoffset': > > > > time.c:242: error: can't find a register in class `HI_REG' while > > reloading > > > > `asm' > > > > ... > > > > > > > > > > > > > /* > > > > > * Due to possible jiffies inconsistencies, we need to check > > > > > @@ -339,7 +339,7 @@ > > > > > : "r" (timerhi), "m" (timerlo), > > > > > "r" (tmp), "r" (USECS_PER_JIFFY), > > > > > "r" (USECS_PER_JIFFY_FRAC) > > > > > - : "hi", "lo", "accum"); > > > > > + : "hi", "lo", "hi"); > > > > > cached_quotient = quotient; > > > > > > > > > Maybe this hunk where you use "hi" twice for the same asm statement? > > > > Yeah, that's messed up, but it fails here too: > > > > @@ -242,7 +242,7 @@ > > __asm__("multu %1,%2" > > : "=h" (res) > > : "r" (count), "r" (sll32_usecs_per_cycle) > > - : "lo", "accum"); > > + : "lo", "hi"); > > Because the asm is outputting something in HI - see the =h? Oh... yeah, I guess gcc knows that the output is clobbered. :-P So just remove the accum clobbers? Regards, Brad