From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 16 Aug 2007 14:19:44 +0100 (BST) Received: from hellhawk.shadowen.org ([80.68.90.175]:62980 "EHLO hellhawk.shadowen.org") by ftp.linux-mips.org with ESMTP id S20021942AbXHPNTg (ORCPT ); Thu, 16 Aug 2007 14:19:36 +0100 Received: from [212.104.150.41] (helo=localhost.localdomain) by hellhawk.shadowen.org with esmtpa (Exim 4.50) id 1ILfYD-0000Bz-LA; Thu, 16 Aug 2007 14:38:13 +0100 Received: from localhost ([127.0.0.1] helo=localhost.localdomain) by localhost.localdomain with esmtp (Exim 4.63) (envelope-from ) id 1ILfFN-00020p-VL; Thu, 16 Aug 2007 14:18:46 +0100 From: Andy Whitcroft To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Andrew Morton , Andy Whitcroft , Andy Whitcroft , Ralf Baechle , linux-mips@linux-mips.org Subject: [PATCH 1/6] mips: irix_getcontext will always fail EFAULT References: InReply-To: Message-ID: <0b4bc89aa61d97708ca0f79ba02f6e60@pinky> Date: Thu, 16 Aug 2007 14:18:45 +0100 Received-SPF: none X-SPF-Guess: neutral Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 16204 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: apw@shadowen.org Precedence: bulk X-list: linux-mips Seems that a trailing ';' has slipped onto the end of the access_ok check here, such that we will always return -EFAULT. Signed-off-by: Andy Whitcroft Cc: Ralf Baechle Cc: linux-mips@linux-mips.org --- arch/mips/kernel/irixsig.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c index 6980deb..28b2a8f 100644 --- a/arch/mips/kernel/irixsig.c +++ b/arch/mips/kernel/irixsig.c @@ -725,7 +725,7 @@ asmlinkage int irix_getcontext(struct pt_regs *regs) current->comm, current->pid, ctx); #endif - if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx))); + if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx))) return -EFAULT; error = __put_user(current->thread.irix_oldctx, &ctx->link); From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hellhawk.shadowen.org ([80.68.90.175]:62980 "EHLO hellhawk.shadowen.org") by ftp.linux-mips.org with ESMTP id S20021942AbXHPNTg (ORCPT ); Thu, 16 Aug 2007 14:19:36 +0100 From: Andy Whitcroft Subject: [PATCH 1/6] mips: irix_getcontext will always fail EFAULT References: Message-ID: <0b4bc89aa61d97708ca0f79ba02f6e60@pinky> Date: Thu, 16 Aug 2007 14:18:45 +0100 Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Andrew Morton , Andy Whitcroft Andy Whitcroft , Ralf Baechle , linux-mips@linux-mips.org Message-ID: <20070816131845.RlisAGDh3EVrc6ekdmMQQit29-BGb5ipGw24FyHWqIo@z> Seems that a trailing ';' has slipped onto the end of the access_ok check here, such that we will always return -EFAULT. Signed-off-by: Andy Whitcroft Cc: Ralf Baechle Cc: linux-mips@linux-mips.org --- arch/mips/kernel/irixsig.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c index 6980deb..28b2a8f 100644 --- a/arch/mips/kernel/irixsig.c +++ b/arch/mips/kernel/irixsig.c @@ -725,7 +725,7 @@ asmlinkage int irix_getcontext(struct pt_regs *regs) current->comm, current->pid, ctx); #endif - if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx))); + if (!access_ok(VERIFY_WRITE, ctx, sizeof(*ctx))) return -EFAULT; error = __put_user(current->thread.irix_oldctx, &ctx->link);