Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Dan Malek <dan@embeddededge.com>
To: ppopov@embeddedalley.com
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
	"'linux-mips@linux-mips.org'" <linux-mips@linux-mips.org>
Subject: Re: patch / rfc
Date: Fri, 26 Aug 2005 11:47:36 -0400	[thread overview]
Message-ID: <0cc66f0b0b5afa994744547699f687bf@embeddededge.com> (raw)
In-Reply-To: <1125069898.14435.1215.camel@localhost.localdomain>


On Aug 26, 2005, at 11:24 AM, Pete Popov wrote:

>> void (*plat_setup_late)(void);
>> [...]
>> 	if (plat_setup_late)
>> 		plat_setup_late()
>>
>> or something like that.
>
> Sure, we can do that.

If you do this, I suggest using another PowerPC-ism.  They
have a ppc_md data structure that is filled with indirect function
pointers to machine dependent functions.  We could create
a mips_md that does this same thing.  The reason I like this
is it collects all machine dependent information in a single
place, so it's easy to see what functions/data are available
and what you may need to do.  It's also clear when used
that anything in this structure is a machine/board dependent
function.  In the proper places, you then do what is shown above:

	if (mips_md.plat_setup_late)
		mips_md.plat_setup_late();

Your earliest machine dependent set up can then fill this in
based upon board options, or you can statically set it up if
you need it even earlier and change it later.

Thanks.

	-- Dan

  reply	other threads:[~2005-08-26 15:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-25 21:51 patch / rfc Pete Popov
2005-08-26 13:10 ` Maciej W. Rozycki
2005-08-26 15:24   ` Pete Popov
2005-08-26 15:47     ` Dan Malek [this message]
2005-08-26 15:53       ` Maciej W. Rozycki
2005-08-26 16:38         ` Dan Malek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cc66f0b0b5afa994744547699f687bf@embeddededge.com \
    --to=dan@embeddededge.com \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    --cc=ppopov@embeddedalley.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox