Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Aleksander Jan Bajkowski <olek2@wp.pl>,
	tsbogend@alpha.franken.de, hauke@hauke-m.de, davem@davemloft.net,
	kuba@kernel.org, netdev@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] net: lantiq_xrx200: convert to build_skb
Date: Tue, 4 Jan 2022 09:42:08 -0800	[thread overview]
Message-ID: <0db849a8-2708-6412-301d-fe77b2cf8d00@gmail.com> (raw)
In-Reply-To: <20220104151144.181736-4-olek2@wp.pl>


On 1/4/22 07:11, Aleksander Jan Bajkowski wrote:
> We can increase the efficiency of rx path by using buffers to receive
> packets then build SKBs around them just before passing into the network
> stack. In contrast, preallocating SKBs too early reduces CPU cache
> efficiency.
>
> NAT Performance results on BT Home Hub 5A (kernel 5.10.89, mtu 1500):
>
> 	Down		Up
> Before	577 Mbps	648 Mbps
> After	624 Mbps	695 Mbps
>
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---


Not sure why GRO is not yet implemented in this driver...



  reply	other threads:[~2022-01-04 17:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 15:11 [PATCH net-next 0/3] net: lantiq_xrx200: improve ethernet performance Aleksander Jan Bajkowski
2022-01-04 15:11 ` [PATCH net-next 1/3] MIPS: lantiq: dma: increase descritor count Aleksander Jan Bajkowski
2022-01-04 15:11 ` [PATCH net-next 2/3] net: lantiq_xrx200: increase napi poll weigth Aleksander Jan Bajkowski
2022-01-04 15:11 ` [PATCH net-next 3/3] net: lantiq_xrx200: convert to build_skb Aleksander Jan Bajkowski
2022-01-04 17:42   ` Eric Dumazet [this message]
2022-01-08 16:44     ` Aleksander Bajkowski
2022-01-06  1:30 ` [PATCH net-next 0/3] net: lantiq_xrx200: improve ethernet performance patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0db849a8-2708-6412-301d-fe77b2cf8d00@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=hauke@hauke-m.de \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olek2@wp.pl \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox