* [PATCH v2 1/1] clk: imgtec: use %pe for better readability of errors while printing
[not found] <CGME20240412090801epcas5p1beb5c87f7582cf4f53c245a642468763@epcas5p1.samsung.com>
@ 2024-04-12 9:07 ` Onkarnarth
2025-03-04 20:15 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Onkarnarth @ 2024-04-12 9:07 UTC (permalink / raw)
To: paulburton, mturquette, sboyd
Cc: linux-mips, linux-clk, linux-kernel, r.thapliyal, maninder1.s,
Onkarnath
From: Onkarnath <onkarnath.1@samsung.com>
instead of printing errros as a number(%ld), it's better to print in string
format for better readability of logs.
Signed-off-by: Onkarnath <onkarnath.1@samsung.com>
---
v1 -> v2 : Removed unnecessary SOB tag.
drivers/clk/imgtec/clk-boston.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/imgtec/clk-boston.c b/drivers/clk/imgtec/clk-boston.c
index b00cbd045af5..db96f8bea630 100644
--- a/drivers/clk/imgtec/clk-boston.c
+++ b/drivers/clk/imgtec/clk-boston.c
@@ -67,21 +67,21 @@ static void __init clk_boston_setup(struct device_node *np)
hw = clk_hw_register_fixed_rate(NULL, "input", NULL, 0, in_freq);
if (IS_ERR(hw)) {
- pr_err("failed to register input clock: %ld\n", PTR_ERR(hw));
+ pr_err("failed to register input clock: %pe\n", hw);
goto fail_input;
}
onecell->hws[BOSTON_CLK_INPUT] = hw;
hw = clk_hw_register_fixed_rate(NULL, "sys", "input", 0, sys_freq);
if (IS_ERR(hw)) {
- pr_err("failed to register sys clock: %ld\n", PTR_ERR(hw));
+ pr_err("failed to register sys clock: %pe\n", hw);
goto fail_sys;
}
onecell->hws[BOSTON_CLK_SYS] = hw;
hw = clk_hw_register_fixed_rate(NULL, "cpu", "input", 0, cpu_freq);
if (IS_ERR(hw)) {
- pr_err("failed to register cpu clock: %ld\n", PTR_ERR(hw));
+ pr_err("failed to register cpu clock: %pe\n", hw);
goto fail_cpu;
}
onecell->hws[BOSTON_CLK_CPU] = hw;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] clk: imgtec: use %pe for better readability of errors while printing
2024-04-12 9:07 ` [PATCH v2 1/1] clk: imgtec: use %pe for better readability of errors while printing Onkarnarth
@ 2025-03-04 20:15 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2025-03-04 20:15 UTC (permalink / raw)
To: Onkarnarth, mturquette, paulburton
Cc: linux-mips, linux-clk, linux-kernel, r.thapliyal, maninder1.s,
Onkarnath
Quoting Onkarnarth (2024-04-12 02:07:49)
> From: Onkarnath <onkarnath.1@samsung.com>
>
> instead of printing errros as a number(%ld), it's better to print in string
> format for better readability of logs.
>
> Signed-off-by: Onkarnath <onkarnath.1@samsung.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-04 20:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20240412090801epcas5p1beb5c87f7582cf4f53c245a642468763@epcas5p1.samsung.com>
2024-04-12 9:07 ` [PATCH v2 1/1] clk: imgtec: use %pe for better readability of errors while printing Onkarnarth
2025-03-04 20:15 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).