From: Justin Carlson <justin@cs.cmu.edu>
To: linux-mips@oss.sgi.com
Cc: ralf@oss.sgi.com
Subject: system.h asm fixes
Date: 17 Jun 2002 11:20:42 -0700 [thread overview]
Message-ID: <1024338042.1463.21.camel@localhost.localdomain> (raw)
Looks to me like we're missing some proper asm clobber markers:
diff -u -r1.13 system.h
--- system.h 4 Feb 2002 17:35:51 -0000 1.13
+++ system.h 17 Jun 2002 18:18:56 -0000
@@ -41,7 +41,8 @@
"__sti"
: /* no outputs */
: /* no inputs */
- : "memory");
+ : "$1","memory"
+ );
}
/*
@@ -73,7 +74,7 @@
"__cli"
: /* no outputs */
: /* no inputs */
- : "memory");
+ : "$1","memory");
}
__asm__ (
@@ -110,7 +111,7 @@
"__save_and_cli\t%0" \
: "=r" (x) \
: /* no inputs */ \
- : "memory")
+ : "$1","memory")
__asm__(".macro\t__restore_flags flags\n\t"
".set\tpush\n\t"
@@ -136,7 +137,7 @@
"__restore_flags\t%0" \
: "=r" (__tmp1) \
: "0" (flags) \
- : "memory"); \
+ : "$1","memory"); \
} while(0)
#ifdef CONFIG_SMP
next reply other threads:[~2002-06-17 18:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-17 18:20 Justin Carlson [this message]
2002-06-17 19:43 ` system.h asm fixes Daniel Jacobowitz
2002-06-17 19:58 ` Thiemo Seufer
2002-06-17 20:44 ` Ralf Baechle
2002-06-17 22:36 ` Thiemo Seufer
2002-06-17 22:57 ` Justin Carlson
2002-06-18 0:52 ` Ralf Baechle
2002-06-19 17:16 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1024338042.1463.21.camel@localhost.localdomain \
--to=justin@cs.cmu.edu \
--cc=linux-mips@oss.sgi.com \
--cc=ralf@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox