From: Gregory Nutt <greg.nutt@cadenux.com>
To: linux-mips@linux-mips.org
Subject: Au1100 Serial Driver
Date: Wed, 06 Oct 2004 08:59:12 -0600 [thread overview]
Message-ID: <1097074752.9253.17.camel@spudrun> (raw)
In-Reply-To: <1097074271.9253.8.camel@spudrun>
I think I see an error in the serial driver for the Au1100. In the
function serial8250_isa_init_ports() there is the line:
up->port.uartclk = get_au1x00_uart_baud_base();
Shouldn't this be:
up->port.uartclk = get_au1x00_uart_baud_base() * 16;
Isn't the UART clock (normally) 16x the baud_base for this (and most)
UARTs?
Also... beware of:
baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16);
quot = serial8250_get_divisor(port, baud);
quot = 0x35; /* FIXME */
For me, 0x35 is not correct. For me, the above 16x fix eliminates
the need for this kind of FIXME.
Greg
--
Gregory Nutt <greg.nutt@cadenux.com>
Cadenux, LLC
next prev parent reply other threads:[~2004-10-06 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-06 14:51 gcc 3.4 / bad_unaligned_access_length Gregory Nutt
2004-10-06 14:59 ` Gregory Nutt [this message]
2004-10-10 2:38 ` Au1100 Serial Driver Pete Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097074752.9253.17.camel@spudrun \
--to=greg.nutt@cadenux.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox