Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: "d.piccolo" <d.piccolo@exadron.com>
To: linux-mips@linux-mips.org
Subject: Bug detection and correction on Alchemy au1x00_uart.c serial driver
Date: Mon, 18 Apr 2005 13:02:08 +0200	[thread overview]
Message-ID: <1113822129.3261.42.camel@localhost.localdomain> (raw)

Hi Everybody

I've found a bug in the  au1x00_uart.c file in the drivers/serial/
directory of the 2.6.10 linux kernel. There is only possible to change
the speed of the communication but not to update other parameters of the
serial link, like the number of bits involved, stop bits and parity.
  Comparing the code of this source file with the code of the standard
8250 driver (8250.c also present in the same directory) I've found the
problem:  au1x00_uart.c never updates the LCR register  (Line Control
Register) of the serial controller at runtime, it happens only at first
setup. The problem is solved by adding the line

	serial_out(up, UART_LCR, cval);

just before the line 
 
	up->lcr = cval;	  /* Save LCR */

(there is only one position in all the source code where is written
"Save LCR")

I hope it could be useful.
                              David Piccolo


    

             reply	other threads:[~2005-04-18 10:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-18 11:02 d.piccolo [this message]
2005-04-21  5:08 ` Bug detection and correction on Alchemy au1x00_uart.c serial driver Pete Popov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1113822129.3261.42.camel@localhost.localdomain \
    --to=d.piccolo@exadron.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox